Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak `m.trust` #2516

Merged
merged 4 commits into from Aug 17, 2019

Conversation

@isiahmeadows
Copy link
Collaborator

commented Aug 17, 2019

Description

  • Fix double-rendering of trusted content within contenteditable elements
  • Fix error on m.trust updating

Motivation and Context

Fixes #2502
Fixes #2498

How Has This Been Tested?

Added new tests for each and verified each failed without the appropriate fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@project-bot project-bot bot added this to Needs triage in Triage/bugs Aug 17, 2019

Actually return the check from `maybeSetContentEditable`
Lots of code paths relied on it being a boolean. When I created the
abstraction, I apparently forgot to make sure it returned the result.

@isiahmeadows isiahmeadows force-pushed the isiahmeadows:unbreak-m-trust branch from 445b401 to cc47788 Aug 17, 2019

@isiahmeadows isiahmeadows merged commit 30ad45c into MithrilJS:next Aug 17, 2019

Triage/bugs automation moved this from Needs triage to Closed Aug 17, 2019

@isiahmeadows isiahmeadows deleted the isiahmeadows:unbreak-m-trust branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.