Generate routes for data coming in from outside phenomic #732

Open
ben-eb opened this Issue Sep 6, 2016 · 2 comments

Projects

TODO in Roadmap

3 participants

@ben-eb
Collaborator
ben-eb commented Sep 6, 2016 edited

Currently, pages such as http://cssnano.co/optimisations/discardDuplicates will respond with a 404 error code on initial load, then the routing will kick in and display the page. This is because the data for this page comes from outside phenomic:

https://github.com/ben-eb/cssnano/blob/2ad9e47263efc6581dec1cd45ad1b2e20b9d49ab/docs/web_modules/app/metadata.js#L27

The page is then routed here:

https://github.com/ben-eb/cssnano/blob/2ad9e47263efc6581dec1cd45ad1b2e20b9d49ab/docs/web_modules/app/routes.js#L32-L35

And the page itself:

https://github.com/ben-eb/cssnano/blob/2ad9e47263efc6581dec1cd45ad1b2e20b9d49ab/docs/web_modules/layouts/Optimisations/show.js#L18

Ideally, we should be able to tell phenomic that this is a real page somehow, so that a 404 isn't thrown.

@MoOx
Owner
MoOx commented Sep 6, 2016

I will implement a workaround so you can have this before we handle the big change related to #713 :)

@ben-eb ben-eb added a commit to ben-eb/cssnano that referenced this issue Nov 2, 2016
@ben-eb ben-eb Workaround for MoOx/phenomic#732. c05dcd3
This was referenced Nov 22, 2016
@bloodyowl
Collaborator

Going to be fixed with #925

@MoOx MoOx referenced this issue Jan 12, 2017
Open

1.0 #936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment