incompatible function pointer types in src/6model/containers.c on Android

[bduggan]

Hello,

When compiling moarVM on android (in termux), following the instructions at https://borg.moe/building-rakudo-perl-6-on-termux.html, I get the error below:

src/6model/containers.c:117:5: error: incompatible function pointer types initializing 'void (*)(MVMThreadContext *, MVMObject *, MVMuint64)' (aka 'void (*)(struct MVMThreadContext *, struct MVMObject *, unsigned long)') with an expression of type 'void (MVMThreadContext *, MVMObject *, MVMint64)' (aka 'void (struct MVMThreadContext *, struct MVMObject *, long)') [-Wincompatible-function-pointer-types]
    code_pair_store_i, /* FIXME need a code_pair_store_u but lacking tests showing this need */
    ^~~~~~~~~~~~~~~~~
src/6model/containers.c:374:5: error: incompatible function pointer types initializing 'void (*)(MVMThreadContext *, MVMObject *, MVMuint64)' (aka 'void (*)(struct MVMThreadContext *, struct MVMObject *, unsigned long)') with an expression of type 'void (MVMThreadContext *, MVMObject *, MVMint64)' (aka 'void (struct MVMThreadContext *, struct MVMObject *, long)') [-Wincompatible-function-pointer-types]
    value_desc_cont_store_i, /* FIXME need a value_desc_cont_store_u but lacking tests showing this need */
    ^~~~~~~~~~~~~~~~~~~~~~~
2 warnings and 2 errors generated.
make: *** [Makefile:668: src/6model/containers.o] Error 1

I was able to work around these errors and get the compilation to succeed by replacing value_desc_cont_store_i with NULL (and ditto for code_pair_store_i) but I think probably there's a better fix

thanks
Brian

[niner]

The real fix is just adding a type cast. There's nothing wrong with the code there. It's just a warning that some settings exaggerate into an error.