Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017.12 moarvm.org/releases tar file has different src/strings/ops.h than github tag #778

Closed
CurtTilmes opened this issue Jan 9, 2018 · 2 comments

Comments

@CurtTilmes
Copy link

See rakudo/rakudo#1377

Between
http://moarvm.org/releases/MoarVM-2017.12.tar.gz
and
https://github.com/MoarVM/MoarVM/archive/2017.12.tar.gz

This file is different:

diff MoarVM-2017.12/src/strings/ops.h MoarVM/src/strings/ops.h
117,118c117,118
<  * If it is different debug information will be printed out. */
< #define MVM_DEBUG_NFG 1
---
>  * If it is different debug information will be printed out.
> #define MVM_DEBUG_NFG 1 */
120,121c120,121
<  * always checks every grapheme manually. Slower. (requires MVM_DEBUG_NFG) */
< #define MVM_DEBUG_NFG_STRICT 1
---
>  * always checks every grapheme manually. Slower. (requires MVM_DEBUG_NFG)
> #define MVM_DEBUG_NFG_STRICT 0 */
@jnthn
Copy link
Member

jnthn commented Jan 9, 2018

Seems that our make release target could do with a check that the working tree is not dirty; that would have prevented somebody's local changes from ending up in the release. Perhaps a 2017.12.1 would be wise also.

@jnthn
Copy link
Member

jnthn commented Jan 10, 2018

Fixed tarball at http://moarvm.org/releases/MoarVM-2017.12.1.tar.gz and commit to add sanity check to prevent this in the future at ac123bb0b4.

@jnthn jnthn closed this as completed Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants