Skip to content

Do not persist credentials in CI artifacts#1875

Merged
patrickbkr merged 1 commit into
MoarVM:mainfrom
ugexe:patch-23
Dec 17, 2024
Merged

Do not persist credentials in CI artifacts#1875
patrickbkr merged 1 commit into
MoarVM:mainfrom
ugexe:patch-23

Conversation

@ugexe

@ugexe ugexe commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

zizmor reports that the MoarVM will persistent credentials through GitHub Actions artifacts:

zizmor .github/workflows/build_release.yml
2024-12-17T01:34:17.812372Z  WARN zizmor: skipping impostor-commit: can't run without a GitHub API token
2024-12-17T01:34:17.812388Z  WARN zizmor: skipping ref-confusion: can't run without a GitHub API token
2024-12-17T01:34:17.812397Z  WARN zizmor: skipping known-vulnerable-actions: can't run without a GitHub API token
2024-12-17T01:34:17.813247Z  INFO audit: zizmor: 🌈 completed /Users/nlogan/.rakubrew/versions/moar-blead/nqp/MoarVM/.github/workflows/build_release.yml
warning[artipacked]: credential persistence through GitHub Actions artifacts
  --> /Users/nlogan/.rakubrew/versions/moar-blead/nqp/MoarVM/.github/workflows/build_release.yml:21:9
   |
21 |         - name: Checkout repository
   |  _________-
22 | |         uses: actions/checkout@v4
23 | |         with:
24 | |           fetch-tags: 'true'
25 | |           ref: ${{ github.event.ref }}
   | |______________________________________- does not set persist-credentials: false
   |
   = note: audit confidence → Low

warning[artipacked]: credential persistence through GitHub Actions artifacts
  --> /Users/nlogan/.rakubrew/versions/moar-blead/nqp/MoarVM/.github/workflows/build_release.yml:56:9
   |
56 |         - name: Checkout repository
   |  _________-
57 | |         uses: actions/checkout@v4
58 | |         with:
59 | |           fetch-tags: 'true'
60 | |           ref: ${{ github.event.ref }}
   | |______________________________________- does not set persist-credentials: false
   |
   = note: audit confidence → Low

9 findings (7 suppressed): 0 unknown, 0 informational, 0 low, 2 medium, 0 high

See actions/checkout#485 and its comments for more information on setting persist-credentials to false.

This explicitly sets persist-credentials: false to opt out of the potential credential persistence.

@ugexe ugexe changed the title Do not persist tokens in CI artifacts Do not persist credentials in CI artifacts Dec 17, 2024
@patrickbkr patrickbkr merged commit 4ca3abd into MoarVM:main Dec 17, 2024
@ugexe ugexe deleted the patch-23 branch December 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants