[needs rework ] Add 8+ properties and fix several that were working incorrectly #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, Bidi_Mirroring_Glyph now returns a string instead of a string which contains a hex number. The Bidi_Paired_Bracket property has been added. With this change, rakudo.moar now passes all the tests for these two properties.
samcv
changed the title
This has all Emoji properties except ZWJ and Emoji_All (which is just derived from anything that has any of the other Emoji properties). It also adds in IndicSyllabicCategory
samcv
changed the title
samcv
added a commit
to samcv/rakudo
that referenced
this pull request
Dec 25, 2016
With this pull: MoarVM/MoarVM#468 We will have all Emoji properties except Emoji_All. With that change to MoarVM and this change to Rakudo we now pass the roast Emoji property tests (aside from Emoji_All).
Remove the old LineBreak sub that generates the Line_Break Unicode properties. Use the enumerated_property sub which should pull in all the data it was missing before and fix MoarVM#463
samcv
changed the title
samcv
added a commit
to rakudo/rakudo
that referenced
this pull request
Dec 28, 2016
With this pull: MoarVM/MoarVM#468 We will have all Emoji properties except Emoji_All. With that change to MoarVM and this change to Rakudo we now pass the roast Emoji property tests (aside from Emoji_All).
samcv
changed the title
|
Most of these have been added in other commits, but I am going to leave this open as reference until the rest of the values are added. |
|
Closing. Stale and not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emoji properties
Bidi_Paired_Bracket
Bidi_Paired_Bracket_Type
Bidi_Mirroring_Glyph
Indic_Syllabic_Category
East_Asian_Width
Line_Break
Indic_Positional_Category
Jamo_Short_Name
string which contains a hex number.
With this change, rakudo.moar now passes all the tests for these three properties, as well as all the ones it was previously passing (aside from the failures for returning a 1 or 0 instead of True or False, which need to be handled on the Rakudo side).