New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework MVMNFGSynthetic to not store base separately #657

Merged
merged 3 commits into from Sep 3, 2017

Conversation

Projects
None yet
1 participant
@samcv
Member

samcv commented Aug 23, 2017

This is done to (eventually) get Prepend support working. Unlike
all other marks which come after a base character, Prepend characters
come before the base character. All of our current code assumed the
first codepoint of the synthetic is the base character.

For now, we also assume the first codepoint of the synthetic is the
base character, but we now have a base_index which will be able to hold
the index of the base character in the codepoint array.

While this doesn't add Prepend support to everything, this is one step
toward getting that working, and decoupling base codepoints from being
the first codepoint of a synthetic.

Rework MVMNFGSynthetic to not store base separately
This is done to (eventually) get Prepend support working. Unlike
all other marks which come after a base character, Prepend characters
come *before* the base character. All of our current code assumed the
first codepoint of the synthetic is the base character.

For now, we *also* assume the first codepoint of the synthetic is the
base character, but we now have a base_index which will be able to hold
the index of the base character in the codepoint array.

While this doesn't add Prepend support to everything, this is one step
toward getting that working, and decoupling base codepoints from being
the first codepoint of a synthetic.

@samcv samcv force-pushed the samcv:synthetic-array-rework branch from 67c63e6 to f7a29da Aug 23, 2017

samcv added some commits Sep 3, 2017

@samcv samcv merged commit 3bd371f into MoarVM:master Sep 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment