New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ios12 fix #1

Merged
merged 2 commits into from Aug 21, 2018

Conversation

Projects
None yet
2 participants
@dkimitsa

dkimitsa commented Aug 21, 2018

iOS12 fix, changed:

  • thread mach port is not deallocated when thread is saved in GC_mach_threads as it cause thread not being resumed as thread port object can be changed
  • threads are now being suspended without check of suspend_count (as it can be suspended by app)
  • changed logic of resume, now is primary cycle list are threads in GC_mach_threads

dkimitsa added some commits Aug 20, 2018

iOS12 fix, changed:
* thread mach port is not deallocated when thread is saved in GC_mach_threads as it cause thread not being resumed as thread port object can be changed
* threads are now being suspended without check of suspend_count (as it can be suspended by app)
* changed logic of resume, now is primary cycle list are threads in GC_mach_threads
@dkimitsa

This comment has been minimized.

dkimitsa commented Aug 21, 2018

not to be merged till confirmed.
pre-build library for testing and tech details in the post
https://dkimitsa.github.io/2018/08/21/investigating-ios12-beta-crash-vol4/

@florianf florianf merged commit c1e9850 into MobiVM:master Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment