New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ios12 & 12.1 bindings #335

Merged
merged 180 commits into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@dkimitsa
Contributor

dkimitsa commented Nov 9, 2018

These was massive API update as part of iOS12 release which includes new frameworks:

  • AuthenticationServices
  • CarPlay
  • CoreServices
  • IdentityLookupUI
  • NaturalLanguage
  • Network

Also this release delivers lot of API changes to existing framework which, bright highlights are:

  • ARKit 2
  • Metal Performance Shaders;
  • and others

Beside updating API itself cocoatouch receives lot of patches as result of improvement of bro-gen script.

Following was improved:

  • fixed lot of broken enum entires (names were generated cut or prefix was not determinated);
  • exposed missing inherited constructors which added lot of missing constructors;
  • applied inherited configuration that reduce number of config entries to be put in yaml;
  • methods where WithXX was generated were mostly located and correctly renamed (this probably might be a breaking change);
  • lot of different minor fixes in generator;

I keep testing some part of it. Please also check if nothing is broken in libgdx

@florianf

This comment has been minimized.

Collaborator

florianf commented Nov 12, 2018

@Tom-Ski could you test the libgdx side?

@mustii82

This comment has been minimized.

mustii82 commented Nov 12, 2018

@dkimitsa Amazing Work!!!

@dkimitsa

This comment has been minimized.

Contributor

dkimitsa commented Nov 13, 2018

@florianf @Tom-Ski I still plan to test few more cases, also plan to close several issues. lets keep testing.

@costimuraru

This comment has been minimized.

costimuraru commented Nov 17, 2018

nice work 👍

dkimitsa added some commits Nov 18, 2018

* this commit fixes `java.lang.IllegalArgumentException: No @Marshale…
…r found for return type of @GlobalValue method` which happens for globals that operates with blocks. Following code crashes compilation without this change. It wasn't found early as nobody had been using global value that returns a block.

```
    @GlobalValue(symbol="_nw_parameters_configure_protocol_default_configuration", optional=true)
    public static native @block VoidBlock1<NWProtocolOptions> DEFAULT_CONFIGURATION();
```
Network framework:
- generated constant blocks for configurations that were missing
- added string marshalers to make api more friendly
- fixed underlines in names
- NWParameters.copy renamed to NWParameters.copyParameters as otherwise it cause bridge synthetic copy method generated from NSObject that caused `@bridge annotated method must be native` on it
@dkimitsa

This comment has been minimized.

Contributor

dkimitsa commented Nov 18, 2018

@florianf @Tom-Ski I've completed activities, please check and point if there is any issues.
thanks

@florianf florianf merged commit a546ca9 into MobiVM:master Nov 27, 2018

@florianf

This comment has been minimized.

Collaborator

florianf commented Nov 27, 2018

Thanks a bunch!!

@dkimitsa

This comment has been minimized.

Contributor

dkimitsa commented Nov 28, 2018

hi @florianf
it also fixes #324

@dkimitsa dkimitsa deleted the dkimitsa:ios12-bindings branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment