New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons update #132

Merged
merged 3 commits into from Jan 18, 2017

Conversation

Projects
None yet
3 participants
@d12frosted
Member

d12frosted commented Jan 11, 2017

I have just started to work on updating icons. Sharing what I already have. I might decrease size of the unicorn (so it fits better). And I will try to consult with one of my fellow designers about the background gradient colour.

Also I am sharing iTunesArtwork.

This PR misses beta and debug version of icons. Not sure how to implement it yet, so will look for solution.

P. S. I removed old icons. It seems to be working for me without this assets, but if I misses something, just let me know.

@mgmart

This comment has been minimized.

Show comment
Hide comment
@mgmart

mgmart Jan 11, 2017

Member

This PR misses beta and debug version of icons. Not sure how to implement it yet, so will look for solution.

There are placeholders already in the Images asset catalog.

Member

mgmart commented Jan 11, 2017

This PR misses beta and debug version of icons. Not sure how to implement it yet, so will look for solution.

There are placeholders already in the Images asset catalog.

@webframp

This comment has been minimized.

Show comment
Hide comment
@webframp

webframp Jan 12, 2017

Member

Since there are placeholders I'm happy to merge this without Debug and Beta icons, @d12frosted any other reason to wait on this in your opinion? Looks good to me

Member

webframp commented Jan 12, 2017

Since there are placeholders I'm happy to merge this without Debug and Beta icons, @d12frosted any other reason to wait on this in your opinion? Looks good to me

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Jan 12, 2017

Member

There are placeholders already in the Images asset catalog.

@mgmart oh indeed 😸

@d12frosted any other reason to wait on this in your opinion? Looks good to me

@webframp no other reasons 😸 I'll provide other icons ASAP (just want to ask opinion of my friend first as I am no designer).

Member

d12frosted commented Jan 12, 2017

There are placeholders already in the Images asset catalog.

@mgmart oh indeed 😸

@d12frosted any other reason to wait on this in your opinion? Looks good to me

@webframp no other reasons 😸 I'll provide other icons ASAP (just want to ask opinion of my friend first as I am no designer).

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Jan 12, 2017

Member

I have an update, will share it tomorrow.

Member

d12frosted commented Jan 12, 2017

I have an update, will share it tomorrow.

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Jan 13, 2017

Member

I have tuned this icon so unicorn fits much better into rounded square. And also tried with yellowish colour to have a better focus on unicorn. So here are two versions. I wonder which one you prefer.

itunesartwork 2x

itunesartwork 2x

The second one is a little bit unusual. But for some reason I like it 😸 My friend hadn't time to really help me, but it's his idea to use more yellowish colour as a background.

Member

d12frosted commented Jan 13, 2017

I have tuned this icon so unicorn fits much better into rounded square. And also tried with yellowish colour to have a better focus on unicorn. So here are two versions. I wonder which one you prefer.

itunesartwork 2x

itunesartwork 2x

The second one is a little bit unusual. But for some reason I like it 😸 My friend hadn't time to really help me, but it's his idea to use more yellowish colour as a background.

@mgmart

This comment has been minimized.

Show comment
Hide comment
@mgmart

mgmart Jan 13, 2017

Member

The second one, please 🦄

Member

mgmart commented Jan 13, 2017

The second one, please 🦄

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Jan 13, 2017

Member

It looks nice on my device 😸

Member

d12frosted commented Jan 13, 2017

It looks nice on my device 😸

@webframp

This comment has been minimized.

Show comment
Hide comment
@webframp

webframp Jan 13, 2017

Member

second one is good for me, makes a nice break from the old icon too. We can save actually changing the unicorn for v2

Member

webframp commented Jan 13, 2017

second one is good for me, makes a nice break from the old icon too. We can save actually changing the unicorn for v2

@mgmart

This comment has been minimized.

Show comment
Hide comment
@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Jan 15, 2017

Member

I have updated icons (with the yellowish variant). Also I have added debug and beta versions.

Attachments:

  • iTunesArtwork.zip containing 512 and 1024 variants for regular, beta and debug icons.

P. S. For some reason I see strange artefacts around the icon on my phone. Gonna investigate that.

Member

d12frosted commented Jan 15, 2017

I have updated icons (with the yellowish variant). Also I have added debug and beta versions.

Attachments:

  • iTunesArtwork.zip containing 512 and 1024 variants for regular, beta and debug icons.

P. S. For some reason I see strange artefacts around the icon on my phone. Gonna investigate that.

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Jan 15, 2017

Member

Ok, that's something funky with my masks in Sketch.app. Using icons without round corners works perfectly.

Member

d12frosted commented Jan 15, 2017

Ok, that's something funky with my masks in Sketch.app. Using icons without round corners works perfectly.

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Jan 15, 2017

Member

Ok, uploading without any round corners. Thanks @mgmart for the link to this forum.

Attachments:

P. S. Sorry for the spam.

Member

d12frosted commented Jan 15, 2017

Ok, uploading without any round corners. Thanks @mgmart for the link to this forum.

Attachments:

P. S. Sorry for the spam.

@webframp

This comment has been minimized.

Show comment
Hide comment
@webframp

webframp Jan 16, 2017

Member

Nice, looking great. @d12frosted. Ready for me to merge this?

Member

webframp commented Jan 16, 2017

Nice, looking great. @d12frosted. Ready for me to merge this?

@webframp webframp merged commit cab0647 into MobileOrg:develop Jan 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment