New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all warnings are removed #194

Merged
merged 6 commits into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@mgmart
Member

mgmart commented May 15, 2017

Major code changes were necessary!

@mgmart mgmart added this to the v.1.7.4 milestone May 15, 2017

mgmart added some commits May 19, 2017

@mgmart mgmart referenced this pull request May 19, 2017

Merged

Fixes #185 #186

Additional warnings are removed
Sometimes those warnings pop up after a while
@mgmart

This comment has been minimized.

Show comment
Hide comment
@mgmart

mgmart May 24, 2017

Member

Due to unmerged PRs testing of this PR is nearly impossible. Best approach seems to be to handle this PR separately.

Member

mgmart commented May 24, 2017

Due to unmerged PRs testing of this PR is nearly impossible. Best approach seems to be to handle this PR separately.

@webframp

This comment has been minimized.

Show comment
Hide comment
@webframp

webframp Jul 13, 2017

Member

Agree on waiting for this one to go through testflight, will work on getting 1.7.3 out

Member

webframp commented Jul 13, 2017

Agree on waiting for this one to go through testflight, will work on getting 1.7.3 out

mgmart added some commits Jul 15, 2017

@webframp

This comment has been minimized.

Show comment
Hide comment
@webframp

webframp Jul 27, 2017

Member

Next up: this one. @mgmart any reasons to wait on this before merging?

Member

webframp commented Jul 27, 2017

Next up: this one. @mgmart any reasons to wait on this before merging?

@mgmart

This comment has been minimized.

Show comment
Hide comment
@mgmart

mgmart Jul 27, 2017

Member

Not at all. Please keep in mind to do a pod update before building.

Member

mgmart commented Jul 27, 2017

Not at all. Please keep in mind to do a pod update before building.

@webframp

This comment has been minimized.

Show comment
Hide comment
@webframp

webframp Jul 27, 2017

Member

Cool, I figured that might be needed due to 66cee5f

Member

webframp commented Jul 27, 2017

Cool, I figured that might be needed due to 66cee5f

@webframp webframp merged commit 68630d8 into MobileOrg:develop Jul 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mgmart

This comment has been minimized.

Show comment
Hide comment
@mgmart

mgmart Jul 27, 2017

Member

The real breaker is ff250bd 😉

Member

mgmart commented Jul 27, 2017

The real breaker is ff250bd 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment