Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix: Temporary fix for MacOS validator app corruption (#1186)
* Include Mac OS .app in installer artifact.

* Use temurin jdk distro, drop .app from package.

* Don't create the app dmg in gradle.  Instead, create an unsigned
bundle in github workflow.

* Add a comment.

* Switch back to zulu distro.

Co-authored-by: Maxime Armstrong <46797220+maximearmstrong@users.noreply.github.com>
  • Loading branch information
bdferris-v2 and maximearmstrong committed Jun 16, 2022
1 parent 41f8211 commit ef868fa
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/package_installers.yml
Expand Up @@ -44,6 +44,19 @@ jobs:
uses: gradle/gradle-build-action@v2
with:
arguments: jpackage
# Per discussion in https://github.com/MobilityData/gtfs-validator/issues/1183, there is a
# bug with jpackage in Java 17 that caused Mac apps to be left in an ambiguous signing state
# that results in them being reported as 'damaged' when run. As a temporary workaround, we
# unsign the app and repackage as a dmg. This bug could be fixed in the future by upgrading
# to Java 18 or by officially signing the app.
- name: Unsign and package Mac OS app
if: matrix.os == 'macos-latest'
shell: bash
run: |
codesign --remove-signature app/pkg/build/jpackage/GTFS\ Validator.app
appVersion=$(./gradlew cV -q -Prelease.quiet)
appVersion=${appVersion//-SNAPSHOT/}
jpackage --type dmg --name 'GTFS Validator' --app-version ${appVersion} --app-image app/pkg/build/jpackage/GTFS\ Validator.app --dest app/pkg/build/jpackage
- name: Upload Installer
uses: actions/upload-artifact@v2
with:
Expand Down
1 change: 1 addition & 0 deletions app/pkg/build.gradle
Expand Up @@ -111,6 +111,7 @@ jlink {
imageOptions = [
'--icon', "${projectDir}/src/main/icons/Icon.icns"
]
skipInstaller = true
}
}
}
Expand Down

0 comments on commit ef868fa

Please sign in to comment.