Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better internationalization #1

Open
cor3ntin opened this issue Dec 7, 2017 · 5 comments
Open

Better internationalization #1

cor3ntin opened this issue Dec 7, 2017 · 5 comments

Comments

@cor3ntin
Copy link
Contributor

cor3ntin commented Dec 7, 2017

  • Having an html file per lang is not sustainable, the best solution would be to have a javascript-based solution for dynamic translation

  • alternatively, we can have a template system

  • Remove the lang selection menu from the HTML file as that unexpectedly clears the unsaved content

@cor3ntin
Copy link
Contributor Author

cor3ntin commented Dec 7, 2017

See that with @elisabernardoni

@mbonani
Copy link
Contributor

mbonani commented Dec 11, 2017

  • what I understand blockly cannot be dynamically on the choose of the languages
  • template system, I didn't understand
  • I think let people choose the languages has to be maintain. It is possible that the browser by default is in english in a classroom or a computer room and that the users wants is own languages. If we can warn the people that the page will be erased or save automatically the code we is the more logical to not permit them to change languages

@mbonani
Copy link
Contributor

mbonani commented Dec 12, 2017

probably the change of languages do not need the warning, it could wait next improvment

@cor3ntin
Copy link
Contributor Author

I looked at the source code, and there isn't that many translations in each html file and they seem easy to translates from either java-script or a code generator ( in order to reduce the number of html file to maintain). However, it is indeed not designed for dynamic translations.

I thought about it and what would be better than a warning would be a local storage.
When you change the lang, it just saves the data, reload the page with the new lang, display the data again.

@mbonani
Copy link
Contributor

mbonani commented Dec 12, 2017

I think that could be an improvement we do in a second phase. I don't think people want to change every time languages. It will do it one time and then program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants