Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockRotationProcessor -> TemplateProcessorIntegrity #323

Closed
Darkhax opened this issue Dec 26, 2016 · 5 comments
Closed

BlockRotationProcessor -> TemplateProcessorIntegrity #323

Darkhax opened this issue Dec 26, 2016 · 5 comments
Milestone

Comments

@Darkhax
Copy link

@Darkhax Darkhax commented Dec 26, 2016

The BlockRotationProcessor class is used by Mojang's nbt schematic format to handle integrity checks. Integrity is used to lower the accuracy of a loaded structure. For example, if the integrity was 0.90f each block in the structure would have a 10% chance of being loaded as null/air. This class has nothing to do with rotations.

@bs2609
Copy link
Contributor

@bs2609 bs2609 commented Oct 1, 2017

Another one for #514?

@kashike
Copy link
Collaborator

@kashike kashike commented Oct 1, 2017

The suggested name sounds really weird to me. TemplateIntegrityProcessor?

@bs2609
Copy link
Contributor

@bs2609 bs2609 commented Oct 2, 2017

The interface is ITemplateProcessor, and it fits with the 'prefix' style of naming used elsewhere (INamedThing -> NamedThingSubtype), but as it's the only vanilla implementation, it could be changed.

@Darkhax
Copy link
Author

@Darkhax Darkhax commented Oct 2, 2017

In this case the name used isn't important to me, as long as it accurately describes the class. I went with the current suggestion for the reason bs2609 stated.

@kashike kashike added this to the 1.13.0 milestone Mar 16, 2018
@kashike
Copy link
Collaborator

@kashike kashike commented Mar 16, 2018

  • net/minecraft/world/gen/structure/template/BlockRotationProcessornet/minecraft/world/gen/feature/template/IntegrityProcessor
@kashike kashike closed this Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants