Permalink
Commits on Nov 21, 2012
  1. Fixed JavaDoc in JcrNodeTypeManager to no longer say registration can…

    …'t update node types.
    rhauch committed Nov 21, 2012
  2. MODE-1715 Additional correction to the variable replacement logic

    The logic was incorrectly replacing blank values with null values. All works well now.
    rhauch committed Nov 21, 2012
Commits on Nov 13, 2012
  1. MODE-1702 Cleanup Corrupted Teiid Sequencer VDB Test Data

    Forgot to update VDB in the integration project. Also fixed a schema validation error in the VDB manifest.
    elvisisking committed with rhauch Nov 12, 2012
  2. MODE-1487 Add support in the Teiid sequencer for VDB dependencies spe…

    …cified in its "vdb.xml"
    
    Cleaned up debug logging to make it consistent with the rest of ModeShape.
    elvisisking committed with rhauch Nov 8, 2012
  3. MODE-1487 Add support in the Teiid sequencer for VDB dependencies spe…

    …cified in its "vdb.xml"
    
    MODE-1700 Teiid Model Sequencer Throws Error When Model Import Has Annotation
    MODE-1702 Cleanup Corrupted Teiid Sequencer VDB Test Data
    Removed corrupted zip files from test data. Removed ignored tests that used those corrupted zip files.
    Added new VDBs to test data and added tests for those new VDBs. The new vdb.xml file XSD included
    VDB dependendencies and model metadata which uses DDL to define the model. Modified VDB sequencer
    and model sequencer to include these new VDB manifest features. Also added tests that test these
    new features. Fixed an error where the href of a model import was not being processed.
    elvisisking committed with rhauch Nov 8, 2012
  4. MODE-1693 - Added special handling to the case when transactions are …

    …not configured: a dedicated exception should be thrown
    hchiorean committed Nov 13, 2012
Commits on Nov 12, 2012
  1. MODE-1703 Minor improvements

    Based upon feedback, two sections of commented-out code were removed (they'd been there
    for some time) and the Code.Externalizer methods were changed to use constants rather
    than magic numbers for the types of the Code classes.
    rhauch committed Nov 12, 2012
Commits on Nov 10, 2012
  1. MODE-1703 Corrected serialization of Schematic deltas

    Array objects were not being serialized/deserialized properly
    within the delta's operation instances (e.g., PutOperation).
    
    Normally, all SchematicEntry (e.g., Documents containing values
    such as Arrays and other Documents) are serialized using BSON, and
    this works correctly in the non-clustered case. However, in the
    clustered case, the changes made to one Document are recorded to
    create a SchematicEntryDelta that is shipped across the Infinispan
    cluster. (This way we can ship only the changes to the
    SchematicEntry rather than the whole document.) Thus the problem
    only manifest itself in clustered configurations.
    
    The actual problem stemmed from the fact that an
    SchematicEntryDelta and its Operation objects are all
    externalizable (with custom Externalizers). The Operation objects
    can contain individual values, Document or Array objects. These are
    also externalizable, but there was a single DocumentExternalizer
    for both Document and Array objects and the DocumentExternalizer
    wrote/read both to/from BSON.
    
    However, the BSON format (which is simply a binary representation
    of JSON documents, with a few extra value types) is only valid for
    Documents; a standalone Array cannot be written in BSON format.
    
    The solution was to use the DocumentExternalizer for Documents, but
    a new ArrayExternalizer for Arrays. This ArrayExternalizer still
    uses BSON, but it uses a subset of the BSON representation to
    serialize Array objects. But, it does work well and fixes the
    problem.
    
    Quite a few new tests were added to verify that the various
    operations with various parameters are indeed externalizable. The
    tests don't cover all the permuations, but they do attempt to cover
    the different kinds of operations with documents and arrays.
    
    To make the Operation objects easily testable, equals and hashCode
    methods were added to all the Operation subclasses. Additionally,
    all of the externalizers were manually reviewed for asymmetric read
    and write methods (e.g, writing an object to the ObjectOutputStream
    but reading an integer from the ObjectInputStream), and several
    asymmetries were found in the Externalizers for BSON value types
    that ModeShape doesn't currently use, and these asymmetries were
    corrected.
    
    All unit and integration tests pass with these changes.
    rhauch committed Nov 10, 2012
Commits on Nov 9, 2012
Commits on Nov 7, 2012
  1. MODE-1703 fixed problems with invalid deserialization of Path and Add…

    …ValueOperation, still doesn't solve problem as we start to get NullPointerException in ArrayOperation.mutableParent
    Jaroslaw Palka committed Nov 7, 2012
Commits on Oct 25, 2012
Commits on Oct 24, 2012
  1. MODE-1691 Corrected JSON Schema

    Corrected our JSON Schema used to validate our repository configuration files to include fields for JDBC database URL, driver class, username and password. Added several test cases to verify the change works.
    rhauch committed Oct 24, 2012
  2. MODE-1675 - Extracted a separate module for modeshape-client which us…

    …es the standard assembly mechanism to attach (install & deploy) the artifact
    hchiorean committed with rhauch Oct 24, 2012
  3. MODE-1690 Additional fixes to the support for custom authenticators

    Applied several corrections suggested by Horia during the code review.
    rhauch committed Oct 24, 2012
Commits on Oct 23, 2012
  1. MODE-1690 Improved support for custom authenticators

    Prior to this fix, authenticators were used but were lost when the configuration was written back out.
    It was also not possible to dynamically add/remove authenticators via the CLI or other administrative tools.
    
    This change adds all of this functionality.
    rhauch committed Oct 23, 2012
  2. MODE-1689 Added missing no-arg constructor for Metadata

    This constructor was accidentally removed in a recent refactoring (see MODE-1669).
    I've now added a test case that uses externalization (via a file system cache store) and replicates the problem. Adding the no-arg constructor fixes the issue.
    rhauch committed Oct 23, 2012
  3. MODE-1687 - Fixed the registration of unused namespaces when initial …

    …cnd files are configured in the repository
    hchiorean committed Oct 23, 2012
Commits on Oct 19, 2012
  1. MODE-1685 Moved the 'isReference' method to Property

    Prior to this, there were two `isReference(Property)` utility methods (one in SessionNode
    and the other in WritableSessionCache). These were removed and a new method added
    to the org.modeshape.jcr.value.Property interface. This is better because the logic
    is now centralized, and it also allows for the empty, single- and multi-valued Property
    implementations to contain efficient implementations.
    
    (I didn't do this originally because I was trying to minimize the impact of the changes.
    But in reality there are new methods and making this change is far better than having
    duplicate code. Thanks, Horia.)
    rhauch committed Oct 19, 2012
  2. MODE-1685 Deleting nodes now processes REFERENCE properties

    When nodes were removed, their REFERENCE properties were not being processed to
    remove the opposite references (from the target of the REFERENCE to the referrer,
    used for referential integrity and returning the nodes that refer to a particular
    node. As a result, removing the only REFERENCE properties pointing to a particular
    node would incorrectly prevent the removal of the referenced node (even when there
    were no more nodes referring to it).
    
    Added some logic to correctly process these REFERENCE properties when the nodes
    are being removed, ensuring the correctness of the referential integrity states.
    
    Several unit tests were added to first replicate and then verify the correct
    behavior.
    rhauch committed Oct 19, 2012
Commits on Oct 18, 2012
  1. MODE-1684 - Updated the AS7 kit to allow the configuration of the wor…

    …kspace cache container
    hchiorean committed Oct 18, 2012
Commits on Oct 17, 2012
  1. MODE-1679 Corrected querying of REFERENCE properties

    Reference properties were not being queried correctly: the tuple value of REFERENCE property was the string
    representation of the node key rather than the exposed identifier, so this corrects the BasicTupleCollector to
    properly process/generate the result set tuples for such properties. Additionally, multi-valued REFERENCE
    properties were not being joined properly, since the tuple contained the array of identifier strings
    and the join processing component was never looking for arrays.
    
    A half-dozen new query tests were added to JcrQueryManagerTest that replicated all of these situations,
    including some of the more elementary queries that are involved in the joins and/or subqueries. Prior
    to these fixes, all of these tests failed. However, after the corrections were made, all of these tests
    pass.
    rhauch committed Oct 17, 2012