Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
tag: modeshape-2.7.…
Commits on Dec 22, 2011
  1. @rhauch
  2. @rhauch
Commits on Dec 21, 2011
  1. @rhauch

    MODE-1359 Corrected NPE during join evaluation

    rhauch authored
    Added an integration test that verifies the above test code does indeed fail. After fixing the various {{Joinable}} and {{Comparable}} implementations in {{JoinComponent}} (used by both the nested loop join and merge join algorithms, the test code passes. Additionally, all other unit and integration tests pass.
    
    This code will need to be merged into 'master' (for inclusion in 2.7.0.Final) and '3.x' (for inclusion in the 3.0 codebase).
Commits on Dec 17, 2011
  1. @rhauch

    MODE-1350 Improved scalability of SearchEngineIndexer

    rhauch authored
    Changed the SearchEngineIndexer to no longer keep the subgraph read requests in the CompositeRequestChannel, which can cause OutOfMemoryErrors when the workspace content is very large or when it contains large binary values.
Commits on Dec 16, 2011
  1. @rhauch

    MODE-1348 Export changed to limit memory consumption with large binar…

    rhauch authored
    …y values
    
    Exporting a workspace that has a lot of large binary values can result in out-of-memory errors, since the binary values are held in memory. (See MODE-1346 for improvements within the 3.x codebase.) While it'd be very difficult to change how the binary values are handled in 2.x, it should still be possible to modify the export logic to prevent holding all workspace content in-memory.
    
    Therefore, the following changes were made to the export process:
    
    1) After every Binary value on an _unmodified_ property is exported, that binary value is purged from memory and allowed to be garbage collected. Note this makes the binary values unusable (see step 2).
    2) At the end of the export, the node that was exported is refreshed while keeping any transient changes, throwing out of the session's cache all _unmodified_ property values (including the binary values that were purged in step 1).
    
    Note that the above steps only apply to _unmodified_ properties. This is very often the case, as a new session is used to export persisted content from the workspace. However, sessions _with transient changes_ can be exported, which is why the two steps listed above only purge binary values on _unmodified_ properties.
    
    All unit and integration tests pass with these changes.
  2. @rhauch

    MODE-1349 Removed the JPA connector's caching of binary values

    rhauch authored
    Although the binary value content should not be put into the 2nd level cache because of the @Lob
    field, this change removes the LargeValueEntity class from the set of classes that should be
    put into Hibernate's 2nd level cache, thereby removing any concern of caching these potentially
    large values.
    
    All unit and integration tests pass.
  3. @rhauch

    MODE-1324 Added methods to obtain SHA-1 has for a Binary value

    rhauch authored
    Made the org.modeshape.jcr.api.Binary interface no longer deprecated (we're not using it again in
    ModeShape 3.x, too), and added two methods for obtaining the SHA-1 hash of the value's content.
    One of the methods returns the byte[] form of the hash, while the other returns the hexadecimal
    string form of the same hash.
  4. @hchiorean

    MODE-1347 fixed potential deadlock in RepositoryConnectionPool

    hchiorean authored
    -replaced the peek & take operations with one atomic operation (pool)
    -added a couple of tests which test the concurrent get&close connection operations
Commits on Dec 9, 2011
  1. @rhauch

    MODE-1325 Added property to JPA source to control background garbage …

    rhauch authored
    …collection
    
    Some use cases of ModeShape involve uploading files and then rarely (if ever) modifying those values.
    In such cases, the background garbage collection process might be far more detrimental to these applications.
    Therefore, this commit adds a new property to the JPA repository source, allowing such background processing
    and garbage collection to be disabled. Note that this only affects large values (all BINARY values or large
    STRING values), since they can be reused by multiple properties/nodes.
    
    All unit and integration tests pass.
Commits on Dec 5, 2011
  1. @rhauch

    MODE-1328 Minor changes to the custom NodeTypeManager methods

    rhauch authored
    The methods of the org.modeshape.jcr.api.nodetype.NodeTypeManager were renamed
    to 'registerNodeTypes' to mirror the standard methods in the
    javax.jcr.nodetype.NodeTypeManager methods.
  2. @rhauch

    MODE-1328 Added to public API methods to register the node types defi…

    rhauch authored
    …ned in CND & XML files
    
    Added the 'org.modeshape.jcr.api.nodetype.NodeTypeManager' interface that extends the 'javax.jcr.nodetype.NodeTypeManager' interface with new 'registerNodeTypeDefinitions(...)' methods that accept File, URL, or InputStream objects.
    
    A new test class was added to verify the behavior. Also, the 'CndNodeTypeReader' and 'JackrabbitXmlNodeTypeReader' classes have been deprecated.
    
    All unit and integration tests pass.
  3. @rhauch

    MODE-1327 Corrected JPA Source's use of RepositorySourceCapabilities

    rhauch authored
    There were two places where 'RepositorySourceCapabilities' objects were being constructed to replace the existing instance. These were removed and replaced with calls to the 'capabilities.withCreatingWorkspaces(boolean)' and 'capabilities.withUpdates(boolean)' methods (which properly construct and return a new instance).
    
    All unit and integration tests pass with these changes.
    
    Note that these changes should be applied to the 'master' and '3.x' branches.
Commits on Dec 2, 2011
  1. @hchiorean
Commits on Nov 30, 2011
  1. @hchiorean
  2. @hchiorean
Commits on Nov 29, 2011
  1. @rhauch

    MODE-1314 Corrected JPA 2nd-level cache configuration for Hiberante 3.3+

    rhauch authored
    The "cacheProviderClassName" can now safely be set to a {{RegionFactory}} implementation class, and the JPA connector does the appropriate thing. Note that when using a version of Hibernate earlier than 3.3, the class name of the {{ProviderClass}} implementation should be used for the value.
    
    Also, a new property was added to the JPA connector in ModeShape 2.7. The {{cacheManagerLookup}} connector property can now be used when configuring Infinispan 2nd level cache to specify where in JNDI the Infinispan cache manager can be found.
    
    All unit and integration tests pass.
  2. @rhauch

    MODE-1313 Corrected wrapping of exception for invalid identifier

    rhauch authored
    When processing invalid identifiers, the Session.getNodeByIdentifier(String) method
    was throwing an internal exception that should be wrapped in a RepositoryException.
    This commit adds the check for this condition.
    
    All unit and integration tests pass.
  3. @hchiorean
Commits on Nov 22, 2011
  1. @rhauch

    MODE-1309 Corrected query behavior when using residual properties as …

    rhauch authored
    …the join criteria
    
    Found and fixed a couple of problems. First, aliases were not being treated properly,
    so any projected column with an alias was not actually connected to the underlying
    property in the Lucene document. Secondly, the exception reported above was due to an
    unnecessary check, which failed when the column corresponded to a residual property
    (since the residual properties are not in the schema).
    
    Added a number of new unit tests to verify that such queries (including variations)
    are handled correctly. For example, the new tests verify that the criteria can reference
    the aliased columns, even though neither of the supplied queries use the aliases in the criteria.
    
    All unit and integration tests pass with these changes.
Commits on Nov 16, 2011
  1. @hchiorean @rhauch

    MODE-1305 Remove unused i18n methods

    hchiorean authored rhauch committed
     - also a small refactoring of the I18n class
  2. @hchiorean @rhauch

    MODE-1300 Updated Tika version to 1.0

    hchiorean authored rhauch committed
     - cleaned up Aperture mime type detector
     - added an additional test to expose Tika problem parsing PDFContext pdfs
Commits on Nov 14, 2011
  1. @hchiorean
Commits on Nov 11, 2011
  1. @rhauch

    MODE-1298 Added more unit tests to help diagnose

    rhauch authored
    Added several unit tests, plus some 'toString', 'equals', and 'hashCode' methods to the ValueReferences
    class and a 'toString' method to the ValueReference class.
    
    This commit includes no changes that attempt to fix the problem.
Commits on Nov 9, 2011
  1. @hchiorean
Commits on Nov 8, 2011
  1. @hchiorean @rhauch

    MODE-1041 Fixed svn tests on windows

    hchiorean authored rhauch committed
    Instead of loading test resources via Files, the classpath
    should be used.
    
    - see http://jira.codehaus.org/browse/SUREFIRE-219
  2. @hchiorean @rhauch

    MODE-1041 Fixed ddl tests on windows

    hchiorean authored rhauch committed
    Instead of loading test resources via Files, the classpath
    should be used.
    
    - see http://jira.codehaus.org/browse/SUREFIRE-219
  3. @hchiorean @rhauch

    MODE-1041 Fixed zip sequencer tests on windows

    hchiorean authored rhauch committed
    Instead of File.separator, forward slash (/) should've been used
Commits on Nov 7, 2011
  1. MODE-1296 - The properties were being added under the transform:trans…

    Van Halbert authored
    …formed mixin, instead of transform:withSql
Commits on Oct 28, 2011
  1. @rhauch
  2. @rhauch
  3. @rhauch
Commits on Oct 27, 2011
  1. @rhauch

    MODE-1281 Corrected file connector's extra properties storage

    rhauch authored
    When storing extra properties, the file system connector incorrectly wrote an empty multi-valued property
    without the required trailing line separator. One example is the "jcr:predecessors" property, which is empty
    upon first checkin of a 'mix:versionable' node. This caused an exception when reading the property back in.
    
    This change corrects the way such empty properties are written to the file, but also adds logic to the
    method that parses the file's lines to handle reading in files that were written with older versions.
    
    The original problem was replicated with a new unit test and a new integration test, and then the
    reading and writing logic were both independently verified. The new tests now pass.
    
    All unit and integration tests pass.
  2. @rhauch

    MODE-1285 JPA entities are now Serializable

    rhauch authored
    Changed the JPA entities in the JPA connector to all be serializable. They should have been Serializable in the first place, as Hibernate clustered cache implementations require this.
    
    All unit and integration tests pass.
Commits on Oct 25, 2011
  1. @rhauch

    MODE-1283 Corrected use of JNDI context in InfinispanSource

    rhauch authored
    One of several usages of JNID Context was not properly checking for condition where the InfinispanSource
    is not configured with a Context reference (this is used primarily for testing). The other cases where
    JNDI context is used are all properly handled.
  2. Updated console rhq plugin version to 1.0.1

    Van Halbert authored
Something went wrong with that request. Please try again.