Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
tag: modeshape-2.8.…
Commits on Feb 27, 2012
  1. @rhauch
  2. @rhauch
Commits on Feb 24, 2012
  1. @rhauch

    MODE-1252 Added repository name constant in RepositoryFactory

    rhauch authored
    Moved the URL an REPOSITORY_NAME constants from the JcrRepositoryFactory implementation
    class into the existing org.modeshape.jcr.api.RepositoryFactory interface. These
    constants can be used when programmatically defining the parameters to pass to the
    RepositoryFactory.getRepository(Map) method.
    Also added more JavaDoc, and deprecated the constants in the JcrRepositoryFactory class.
    All unit and integration tests pass with these changes.
  2. @hchiorean

    MODE-1403 Added separate profile for testing with Infinispan 4 and 5 …

    hchiorean authored
    ISPN 5 uses a newer version of jboss-logging, therefore when this connector is used, some transitive dependencies need to be disabled
  3. @hchiorean
  4. @hchiorean
  5. @hchiorean

    MODE-1235 Fixed missing exception handling which could cause indefini…

    hchiorean authored
    …te hangs when repository starts up.
    Also, added a test case which reproduces the steps in MODE-1235
Commits on Feb 23, 2012
  1. @hchiorean

    Fixed OSGI dependency for JBossAS - make sure the same version is used

    hchiorean authored
    Without this, the Java Sequencer and the JBoss AS assembly would bring in 2 different versions, causing the Ant script from JBossAS to fail when unsigning the jar.
Commits on Feb 21, 2012
  1. @hchiorean

    MODE-1238 Fixed indexing for federated connectors

    hchiorean authored
    The fix allows changes to be recorded & dispatch always (not only when the source and target of the projection are the same)
Commits on Feb 18, 2012
  1. @hchiorean @rhauch

    MODE-1298 Added test case for cloning binary content across workspace…

    hchiorean authored rhauch committed
    …s in a disk store
Commits on Feb 17, 2012
  1. @hchiorean

    MODE-949 Added integration test for text sequencer, so that any repor…

    hchiorean authored
    …ted issues may be easily verified
Commits on Feb 16, 2012
  1. @rhauch

    MODE-1307 Added Content-Type HTTP header to REST examples

    rhauch authored
    The examples in the RESTful Service chapter did not show including the "Content-Type" HTTP
    header. The service will correctly return JSON if this header or "Content-Type" header is
    supplied in the request. However, an error will result if a different content-Type header
    is provided.
    This change only affects the Reference Guide.
Commits on Feb 14, 2012
  1. @rhauch

    MODE-1401 Corrections to behaviors when nodes are checked in

    rhauch authored
    Corrected several behaviors of what is allowed and not allowed for modifying nodes
    that are checked in, per Section 15.2.2 of the JCR specification. Several new unit
    tests were added that verify these behaviors. These new tests all failed prior to
    these fixes, but they all pass now. (Note this clearly shows the incomplete coverage
    of the TCK versioning tests.)
    All unit and integration tests pass with these changes.
  2. @rhauch

    MODE-1400 Added error/warning checks when registering node types via …

    rhauch authored
    …CND files
    Previously, the CND files were being read but any problems during the reading were not reported and were simply
    ignored. Some errors cause the reader to abort reading and to have successfully read in no node types, so
    registration appeared to do nothing while hiding the errors. With these changes, the errors and warnings
    are included in a thrown exception; if there are no errors and only warnings, the warnings are simply logged.
    All unit and integration tests pass.
  3. @hchiorean @rhauch

    MODE-1279 Removed styling changes and moved NoMoreFederatedRequest in…

    hchiorean authored rhauch committed
    …side finally construct
  4. @hchiorean @rhauch

    MODE-1279 - Fixed repository blocking after performing a full-text se…

    hchiorean authored rhauch committed
    …arch multiple times
    The fix was part of the #207 pull request, which basically removed explicit synchronization around the LuceneSearchProcessor and Engine.
    In addition:
    - the lucene version was updated from 3.1.0 to 3.4.0
    - the LuceneSearchSession was updated to avoid the possible loss of content when indexing the same content in the same workspace from multiple threads
  5. @rhauch

    Merge branch 'MODE-1302' of in…

    rhauch authored
    …to hchiorean-MODE-1302
  6. @rhauch

    MODE-1398 Added new connector for Infinispan 5

    rhauch authored
    Made additional changes/fixes to the Infinispan 4 and 5 connectors and tests.
  7. @hchiorean

    MODE-1302 Fixed session.refresh algorithm

    hchiorean authored
    Two issues fixed:
    - refresh phase 1 - determining which nodes should be left and which should be discarded
    - LinkedListMultimap clear method, which cause refresh phase 2 to incorrectly duplicate existing nodes under a parent, as SNS.
Commits on Feb 11, 2012
  1. @rhauch

    MODE-1398 Added new connector for Infinispan 5

    rhauch authored
    Added a new connector that uses Infinispan 5.x caches for storage. The existing
    Infinispan 4.x connector is still usable, and basically users would choose between
    the two. Note that Infinispan 5.1.1.Final is likely to be used by JBoss AS 7.1.0.Final.
    All unit and integration tests pass.
Commits on Feb 10, 2012
  1. @rhauch

    Corrected compilation errors

    rhauch authored
Commits on Jan 27, 2012
  1. @hchiorean

    MODE-1326 Fixed Oracle DDL exception when parsing CREATE UNIQUE INDEX…

    hchiorean authored
    … statements
     The fix was to implement minimal support for unique index in the Oracle parser and to make sure that only "legal" token are delegated to the standard parser.
Commits on Jan 26, 2012
  1. @hchiorean

    MODE-1377 Fixed webdav repository path parsing with trailing slash.

    hchiorean authored
    - changed request path parsing so that multiple empty '/' characters are collapsed into one.
    - updated pom.xml so that log4j dependency is runtime (this is not ideal, but until slf4j dependencies are changed, this should be there)
Commits on Jan 19, 2012
  1. @hchiorean
  2. @hchiorean
Commits on Jan 18, 2012
  1. @rhauch

    MODE-1374 Corrected node type init errors in concurrent env

    rhauch authored
    The JcrNodeDefinition is intended to be immutable and thread-safe, and although
    it is publicly immutable, internally it delays loading the references to the
    required primary types until needed. The 'ensureRequiredPrimaryTypesLoaded()' method
    is what lazily initializes the references, and this method is properly called in
    the right spots within JcrNodeDefinition. However, in a highly-concurrent environment
    a node type definition may be needed by multiple threads, and this can result
    in this method being called concurrently. Unfortunately this method is not thread-safe,
    and can cause a NullPointerException when used concurrently.
    The 'ensureRequiredPrimaryTypesLoaded()' method just iterates through the names of the
    required primary types (which were set in the constructor), and looks up the JcrNodeType
    instances for each primary type name. It then creates an immutable map to quickly find
    the JcrNodeType instances given the primary type name. Finally, it stores the map
    and the names, and when the array of JcrNodeType instances and map are available
    (non-null), it merely uses the values. But the creation of the JcrNodeType array and
    map keyed by name are not concurrent or atomic. In fact, a non-empty array is created
    (but not initialized, so it contains null references) and _immediately set_ on one of the
    JcrNodeDefinition fields, so when the method is called by other threads it is as if
    the JcrNodeType array is ready to be used. But the original thread hasn't yet set
    the JcrNodeType references in the array, so any other thread that uses the array
    gets a null reference instead, and using that causes the NullPointerException.
    The fix is relatively simple: ensure that the 'requiredPrimaryTypes' array of JcrNodeType
    and 'requiredPrimaryTypesByName' map are set in a synchronized way, ensuring they
    are only set to non-null with an array (or map) that are fully and correctly populated.
    This could be done by simply synchronizing the entire 'ensureRequiredPrimaryTypesLoaded()'
    method, but the method calls out to the RepositoryNodeTypeManager. And while the RNTM
    doesn't currently (directly or indirectly) result in a call to 'ensureRequiredPrimaryTypesLoaded()',
    it's possible it might in the future.  Therefore, we can simply create and fully-populate
    the array and map outside of the synchronization block, and only synchronize upon setting
    it (of course checking before we set it whether another thread snuck in and set it
    while we waited for the lock). So it is effectively the same as synchronizing the method
    (which the reporter says fixes the problem), but does it with smaller lock scope.
    With this change, all unit and integration tests pass.
Commits on Jan 17, 2012
  1. @rhauch

    MODE-1370 Added additional observation tests

    rhauch authored
    Added three unit tests that verified the ObservationManager.setUserData() is being
    set correctly. All tests pass, with no changes to the non-test code, proving the
    code is indeed working correctly.
Commits on Jan 13, 2012
  1. @rhauch

    MODE-1367 Corrected copyright dates for 2012

    rhauch authored
    Updated the two COPYRIGHT.txt files and also updated the two AUTHOR.txt files
    to reflect the contributors.
Commits on Jan 10, 2012
  1. @rhauch

    MODE-1366 Error parsing JCR-SQL2 queries using square brackets for qu…

    rhauch authored
    The JCR-SQL2 grammar uses square brackets for quoting identifiers, node names
    and node paths. However, path literals may also have square brackets around
    the same-name-siblings. The JCR-SQL2 parser was not able to properly parse
    quoted paths with SNS indexes.
    The fix is to adjust the tokenizer to count the number of open and close
    square brackets, and to stop the quoted string token when the all of the opened
    square brackets were closed. Additional unit tests were added to verify the
    tokenizer and JCR-SQL2 parser behavior.
    All unit and integration tests pass with these changes.
  2. @rhauch

    MODE-1362 Corrected integration tests

    rhauch authored
    The JcrDriverIntegrationTest queries the output of the DDL sequencer, and so required
    changes to the expected results to mirror the updated output.
  3. @hchiorean
Commits on Jan 9, 2012
  1. @hchiorean
Commits on Jan 3, 2012
  1. @rhauch

    MODE-1364 Corrected use of reference in join condition

    rhauch authored
    The indexes were not storing the value of REFERENCE or WEAK REFERENCE properties, and thus
    null was returned in the tuples for these records. Consequently, the join could not be performed
    with null values.
    Added several test cases that replicated this problem and now verify the updated code
    exhibits the correct behavior.
Commits on Dec 22, 2011
  1. @rhauch
  2. @rhauch
Something went wrong with that request. Please try again.