Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODE-1435, MODE-1423 #365

Merged
merged 8 commits into from Apr 30, 2012
Merged

MODE-1435, MODE-1423 #365

merged 8 commits into from Apr 30, 2012

Conversation

rhauch
Copy link
Contributor

@rhauch rhauch commented Apr 30, 2012

Completed the ModeShape subsystem for AS7, and made several other corrections.

Corrected the ModeShape subsystem for AS7 so that repository deployments are done correctly and that the RESTful service now correctly exposes all repository content. Additional fixes include:
- all dependencies are represented within AS7 modules,
- Hibernate Search is correctly initialized,
- the XSD for the subsystem XML is renamed to allow for more versions in the future, and
- the XML configuration for the subsystem no longer creates empty elements

The ModeShape Kit for AS7 now installs on top of AS 7.1.0.Final and will automatically start a "sample" repository.
Corrected the JavaDoc for recent changes.
Changed the message in the exception thrown when a repository's configuration is invalid or has problems. The message now includes the list of problems.
Upgraded the Hibernate Search library from 4.0.0.Final to 4.1.0.Final, and corrected a few uses of classes that changed. The build and all tests succeed with these changes.
The JAAS security provider would incorrectly throw an exception whenever it came across a Credentials implementation that it did not know about (or whose class was not accessible to the class loader).
The MongoDB driver is used in some of Schematic's test cases to validate the I/O of the JSON and BSON readers and writers. The version of the MongoDB driver was upgraded to the latest; since this is only used for tests, it has no influence on any non-test artifacts.
ModeShape's parent POM was cleaned up to remove some potential errors and/or warnings.
The @SerializeWith annotation used in the SchematicEntryLiteral class was incorrectly the JavaDoc annotation, but should have been the Java annotation. This was corrected, and the AS7 kit was used to verify that the changed code correctly configures Infinispan to correctly serialize/deserialize the values.
<module name="org.jboss.logging" />
<module name="org.jgroups" />
</dependencies>
</module>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the 'org.hibernate.search.engine' AS7 module, with dependencies on other existing modules and embedded libraries for some of the transitive dependencies. Note that the Jackson ASL libraries are different versions than what's used in AS7, which is why they were embedded in this module.

@rhauch
Copy link
Contributor Author

rhauch commented Apr 30, 2012

@tejones, do you want to look at the changes to the modules added by the kit? Specifically, we're adding 'org.hibernate.search.engine' and 'org.apache.lucene' modules (see line nodes above).

@tejones
Copy link
Member

tejones commented Apr 30, 2012

sure... looking now.

@rhauch rhauch merged commit 3b1577b into ModeShape:master Apr 30, 2012
@tejones
Copy link
Member

tejones commented Apr 30, 2012

While this approach may ultimately be problematic, it seems like the only option. I can imagine this being a common issue for other modules deployed to AS 7.

@rhauch
Copy link
Contributor Author

rhauch commented Apr 30, 2012

Merged into the 'master' branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants