MODE-1562 changed getResourceLength impl #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while (-1 != (bytesRead = is.read(buff, 0, 255))) { | ||
| size += bytesRead; | ||
| if(node == null){ | ||
| throw new IOException("node is null"); | ||
| } |
There was a problem hiding this comment.
Strictly speaking, this null check isn't required per the contract of the ContentMapper interface, which says that Node should never be null. Plus, the place where it's called will never pass in a null Node reference.
|
This is a good fix for the issue. Thanks, @kosch! |
removed null check
|
Removed null check as requested. |
|
Merged onto the 'master' branch and cherry-picked onto the '2.x' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the stream to determine size is extremly slow. I think it was originally implemented due lack of getLength() or different node structure...