From f6df5185d27233d9fe7cccde553dd05f69b35982 Mon Sep 17 00:00:00 2001 From: wuayee Date: Fri, 31 Oct 2025 11:06:09 +0800 Subject: [PATCH] =?UTF-8?q?[app-builder]=20=E5=8E=BB=E9=99=A4=E7=9F=A5?= =?UTF-8?q?=E8=AF=86=E5=BA=93=E8=8A=82=E7=82=B9=E7=9A=84=E5=8F=AF=E8=A1=8C?= =?UTF-8?q?=E6=80=A7=E6=A3=80=E6=9F=A5?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../jober/aipp/service/impl/RetrievalNodeChecker.java | 10 ---------- .../aipp/service/AppBuilderAppServiceImplTest.java | 3 +-- .../fit/jober/aipp/service/CheckerTest.java | 6 +----- 3 files changed, 2 insertions(+), 17 deletions(-) diff --git a/app-builder/plugins/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/service/impl/RetrievalNodeChecker.java b/app-builder/plugins/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/service/impl/RetrievalNodeChecker.java index c8d31bd753..2dc6aa11f4 100644 --- a/app-builder/plugins/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/service/impl/RetrievalNodeChecker.java +++ b/app-builder/plugins/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/service/impl/RetrievalNodeChecker.java @@ -6,14 +6,8 @@ package modelengine.fit.jober.aipp.service.impl; -import modelengine.fit.jane.common.entity.OperationContext; -import modelengine.fit.jober.aipp.dto.check.AppCheckDto; -import modelengine.fit.jober.aipp.dto.check.CheckResult; - import modelengine.fitframework.annotation.Component; -import java.util.List; - /** * 普通检索节点的checker * @@ -22,8 +16,4 @@ */ @Component public class RetrievalNodeChecker extends AbstractNodeChecker { - @Override - public List validate(AppCheckDto appCheckDto, OperationContext context) { - return this.invalidNodeConfig(appCheckDto, appCheckDto.getType()); - } } diff --git a/app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/AppBuilderAppServiceImplTest.java b/app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/AppBuilderAppServiceImplTest.java index b3bdb4c297..af4c61fbc3 100644 --- a/app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/AppBuilderAppServiceImplTest.java +++ b/app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/AppBuilderAppServiceImplTest.java @@ -572,8 +572,7 @@ void testModelNode() { mockedStatic.when(() -> CheckerFactory.getChecker(anyString())).thenReturn(new RetrievalNodeChecker()); List results = this.appBuilderAppService.checkAvailable(Collections.singletonList(appCheckDto), null); - Assertions.assertFalse(results.get(0).isValid()); - Assertions.assertEquals(results.get(0).getConfigChecks().size(), 2); + Assertions.assertTrue(results.isEmpty()); } } diff --git a/app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/CheckerTest.java b/app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/CheckerTest.java index 107cf78d36..ab1b7ee043 100644 --- a/app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/CheckerTest.java +++ b/app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/CheckerTest.java @@ -130,11 +130,7 @@ public void testRetrievalNode() { + "\"createdAt\":\"2024-12-02 12:41:14\",\"checked\":true}]}]}"; AppCheckDto appCheckDto = JsonUtils.parseObject(testNode, AppCheckDto.class); List results = this.retrievalNodeChecker.validate(appCheckDto, null); - Assertions.assertEquals(results.size(), 2); - Assertions.assertFalse(results.get(0).isValid()); - Assertions.assertEquals(results.get(0).getConfigChecks().size(), 2); - Assertions.assertFalse(results.get(1).isValid()); - Assertions.assertEquals(results.get(1).getConfigChecks().size(), 1); + Assertions.assertTrue(results.isEmpty()); } }