[Feature]refactor ucconnector #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Find no location where _load_req_to_blocks is assigned, so the blocks that failed to load cannot be properly returned. |
ygwpz
reviewed
Sep 10, 2025
ygwpz
reviewed
Sep 10, 2025
qyh111
force-pushed
the
dev_qyh_0908
branch
from
50f88e0 to
50ab55d
Compare
Contributor
|
pr title should include [feature] / [xx] |
flesher0813
reviewed
Sep 11, 2025
| assert len(fetch_block_ids) == len(fetch_block_hashes) | ||
| blocks_len = len(fetch_block_ids) | ||
|
|
||
| storage_block_ids = [block[0] for block in request.load_blocks] |
Contributor
There was a problem hiding this comment.
It would be nice to add some comments to help understand this code, block_hash of ReqMeta.load_blocks is storage_block_ids could be confusing
Contributor
Author
There was a problem hiding this comment.
already add comments
| ) | ||
|
|
||
| if request.load_async: | ||
| if request.load_async and request.request_id in self.layerwise_load_tasks: |
Contributor
There was a problem hiding this comment.
Is the judgment of request.request_id in self.layerwise_load_tasks necessary? So as the judgment below
| + save_param.num_blocks_to_save | ||
| ] | ||
| blocks_len = len(vllm_block_ids) | ||
| storage_block_ids = [block[0] for block in request.dump_blocks] |
Contributor
There was a problem hiding this comment.
It would be nice to add some comments to help understand this code too
Contributor
Author
There was a problem hiding this comment.
already add comments
ucm/integration/vllm/uc_connector.py
Outdated
|
|
||
| need_load_tokens = max(num_external_computed_tokens - num_computed_tokens, 0) | ||
| # Load async when Decode instance need to load. | ||
| # Load async when Decode instance need to load.kv_consumer" |
qyh111
force-pushed
the
dev_qyh_0908
branch
from
e475a01 to
628f6fe
Compare
qyh111
force-pushed
the
dev_qyh_0908
branch
from
628f6fe to
ac7b6a3
Compare
Contributor
|
log format should be unified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What this PR does / why we need it?
Fix hole match problem when lookup and create
Remove some unnecessary parameters when build metadata
Modifications
Does this PR introduce any user-facing change?
No just metadata change
Test
Tested by offline inferrence
also use benchmark to test online service
How was this patch tested?
No new patch added