Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

story behind the data #4

Merged
merged 2 commits into from Jan 8, 2019
Merged

story behind the data #4

merged 2 commits into from Jan 8, 2019

Conversation

byrolew
Copy link
Collaborator

@byrolew byrolew commented Dec 29, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 29, 2018

Codecov Report

Merging #4 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #4      +/-   ##
=========================================
- Coverage     8.8%   8.62%   -0.18%     
=========================================
  Files           6       6              
  Lines         193     197       +4     
=========================================
  Hits           17      17              
- Misses        176     180       +4
Impacted Files Coverage Δ
R/predict.R 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c428e...9580e78. Read the comment docs.

Copy link
Member

@pbiecek pbiecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file dragons_diagram.pdf is duplicated in the misc folder and vigniettes folder. Any reason for that?

The pdf format is not good for html vignettes. After pkgdown::build_site() the resulting website does not have the pdf figure included. Please consider the svg format (vector but www friendly) or png in case of problems.

The description is ok and the diagram is ok, but please add following:

  • formula used for generation of data (might be in R code copied from Rd file)
  • head(dragons) as the illustration how the data looks like
  • example code that generates a randomForest model and an explainer (two lines, one for model one for explainer). Then one can easily recreate the explainer in Rconsole.

Optionally:
What about adding a silhouette of a dragon from the presentation? Will be more eye catching.

@byrolew
Copy link
Collaborator Author

byrolew commented Jan 4, 2019

The reason is I added it long ago to misc and forgot about it. I'll delete it.

I don't see the point in creating an explainer here if it's only a data set. Such example should be in the vignette for the explainer.

As for the rest: sure, will do :)

@pbiecek pbiecek merged commit 6503fb9 into master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants