Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong values in shap sign column #82

Closed
hbaniecki opened this issue Apr 14, 2020 · 0 comments · Fixed by #83
Closed

Wrong values in shap sign column #82

hbaniecki opened this issue Apr 14, 2020 · 0 comments · Fixed by #83
Labels
invalid ❕ This doesn't seem right

Comments

@hbaniecki
Copy link
Member

The sign column should be updated on new values of the contribution column.

extracted_contributions <- sapply(result, function(chunk) {
chunk[order(chunk$label, chunk$variable), "contribution"]
})
result_average <- result[[1]]
result_average <- result_average[order(result_average$label, result_average$variable),]
result_average$contribution <- rowMeans(extracted_contributions)
result_average$B <- 0
result <- c(list(result_average), result)

@hbaniecki hbaniecki added the invalid ❕ This doesn't seem right label Apr 14, 2020
hbaniecki pushed a commit that referenced this issue Apr 14, 2020
pbiecek pushed a commit that referenced this issue Apr 18, 2020
* fix #82

* version update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ❕ This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant