New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why we have two ^2 ? #79

Closed

pbiecek opened this issue Dec 9, 2019 · 2 comments

Member

pbiecek commented Dec 9, 2019

ingredients/R/aggregate_profiles.R

Line 200 in ccb18f9

diffsd <- sqrt(mean(diffs^2))

Member Author

pbiecek commented Dec 9, 2019

square weights will be replaced by gaussian kernel weights.
More readable, similar effect

Member Author

pbiecek commented Dec 10, 2019

The gaussian kernel weights are described in https://pbiecek.github.io/PM_VEE/accumulatedLocalProfiles.html#conditional-dependency-profile

pbiecek added a commit that referenced this issue


          candidate fix for #79

d112f69

pbiecek closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment