-
Notifications
You must be signed in to change notification settings - Fork 284
fix: minor updates and fixs for unit_tests to match current code #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @WuSiYu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on synchronizing various unit tests with recent changes in the codebase. The updates ensure that tests for Triton kernel parameter generation, fused MoE softmax operations, sampling parameter handling, and shared memory request management accurately reflect the current function signatures and object structures. These adjustments are essential for maintaining the integrity and reliability of the test suite. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily updates unit tests to align with recent code changes. The modifications across the test files correctly reflect new function signatures and data structures. I've identified one issue in test_shm_req_manager.py where the test fixture's teardown logic is incomplete, which could compromise test isolation. A code suggestion is provided to fix this.
| if original: | ||
| os.environ["LIGHTLLM_START_ARGS"] = original |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The teardown logic for the environment variable is incomplete. If LIGHTLLM_START_ARGS was not set before this fixture ran, original will be None, and the if original: check will be false. This causes the environment variable set by the test to leak into other test modules, potentially causing flaky tests. The teardown should ensure the environment variable is removed if it wasn't present initially.
| if original: | |
| os.environ["LIGHTLLM_START_ARGS"] = original | |
| if original is not None: | |
| os.environ["LIGHTLLM_START_ARGS"] = original | |
| else: | |
| os.environ.pop("LIGHTLLM_START_ARGS", None) |
dd7fe24 to
f4cfaa3
Compare
No description provided.