Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

canPlayType returned 'no' instead of '' in some versions. We now hand…

…le this. fixes #334
  • Loading branch information...
commit a872a3448bb1c49bc3b3dbdcc2838ccba977c8a8 1 parent baf55b2
@paulirish paulirish authored
Showing with 12 additions and 10 deletions.
  1. +4 −2 compress.sh
  2. +8 −8 modernizr.js
View
6 compress.sh
@@ -1,4 +1,6 @@
-#/bin/bash
+#/bin/sh
+
+# sudo npm install -g uglify-js
IN=modernizr.js
OUT=modernizr.min.js
@@ -10,4 +12,4 @@ echo $SIZE_MIN bytes minified, $SIZE_GZIP bytes gzipped
if [ "$1" == "--test" ]; then
rm "$OUT"
-fi
+fi
View
16 modernizr.js
@@ -617,7 +617,6 @@ window.Modernizr = (function( window, document, undefined ) {
// Note: in some older browsers, "no" was a return value instead of empty string.
// It was live in FF3.5.0 and 3.5.1, but fixed in 3.5.2
// It was also live in Safari 4.0.0 - 4.0.4, but fixed in 4.0.5
- // Modernizr does not normalize for this.
tests['video'] = function() {
var elem = document.createElement('video'),
@@ -627,11 +626,11 @@ window.Modernizr = (function( window, document, undefined ) {
try {
if ( bool = !!elem.canPlayType ) {
bool = new Boolean(bool);
- bool.ogg = elem.canPlayType('video/ogg; codecs="theora"');
+ bool.ogg = elem.canPlayType('video/ogg; codecs="theora"') .replace(/^no$/,'');
- bool.h264 = elem.canPlayType('video/mp4; codecs="avc1.42E01E"');
+ bool.h264 = elem.canPlayType('video/mp4; codecs="avc1.42E01E"') .replace(/^no$/,'');
- bool.webm = elem.canPlayType('video/webm; codecs="vp8, vorbis"');
+ bool.webm = elem.canPlayType('video/webm; codecs="vp8, vorbis"').replace(/^no$/,'');
}
} catch(e) { }
@@ -646,14 +645,15 @@ window.Modernizr = (function( window, document, undefined ) {
try {
if ( bool = !!elem.canPlayType ) {
bool = new Boolean(bool);
- bool.ogg = elem.canPlayType('audio/ogg; codecs="vorbis"');
- bool.mp3 = elem.canPlayType('audio/mpeg;');
+ bool.ogg = elem.canPlayType('audio/ogg; codecs="vorbis"').replace(/^no$/,'');
+ bool.mp3 = elem.canPlayType('audio/mpeg;') .replace(/^no$/,'');
// Mimetypes accepted:
// developer.mozilla.org/En/Media_formats_supported_by_the_audio_and_video_elements
// bit.ly/iphoneoscodecs
- bool.wav = elem.canPlayType('audio/wav; codecs="1"');
- bool.m4a = elem.canPlayType('audio/x-m4a;') || elem.canPlayType('audio/aac;');
+ bool.wav = elem.canPlayType('audio/wav; codecs="1"') .replace(/^no$/,'');
+ bool.m4a = ( elem.canPlayType('audio/x-m4a;') ||
+ elem.canPlayType('audio/aac;')) .replace(/^no$/,'');
}
} catch(e) { }
Please sign in to comment.
Something went wrong with that request. Please try again.