Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up travis CI integration #490

Closed
paulirish opened this issue Feb 8, 2012 · 16 comments
Closed

set up travis CI integration #490

paulirish opened this issue Feb 8, 2012 · 16 comments

Comments

@paulirish
Copy link
Member

We'd probably use their new phantomJS support and run the tests within qunit in phantom.

I'm not sure how to set this up but having some CI checking to go along with distributed development would be phenomenal

@ryanseddon
Copy link
Member

We'll need to do these 2 steps to get started

And I think this is a great idea, and also we could include the build status image right into the readme!

@ryanseddon
Copy link
Member

Looks like ember.js has travis-ci integration using phantomjs so we should steal their config and alter it for our needs https://github.com/emberjs/ember.js/blob/master/.travis.yml

@paulirish
Copy link
Member Author

Yup i like that plan.

@ryanseddon
Copy link
Member

Sweet do you wanna give access to travis-ci through the modernizr account and then we can do a branch to play around with it.

@paulirish
Copy link
Member Author

Sure.

ryanseddon added a commit that referenced this issue Feb 10, 2012
@ryanseddon
Copy link
Member

Well that was a lot easier than I thought it would be! Seems to be passing \o/

Errr scratch that it's just exiting out for some reason.

@paulirish
Copy link
Member Author

sooooo awesomeee

merge into master whenever you like!

@ryanseddon
Copy link
Member

It's not actually running the tests though according to the last test, it creates a server and I pass it the run-qunit.js file and the test suite page but it says it's "Unable to acces network"? Phantomjs should scrape the html and output the tests in the build page but it doesn't show anything...

If anyone knows what I'm doing wrong please let me know.

@ryanseddon
Copy link
Member

We have travis-ci working and running through the tests! http://travis-ci.org/#!/Modernizr/Modernizr/builds/725178

At the moment whenever we commit to master or any other branch that isn't travis-ci the build will fail as there is no config file for it to use and it tries to run a ruby gem file (default behaviour).

On the travis-ci branch one test is failing with the caniuse data and it's not pulling in the feature-detect tests which are 404'ing cause I think it's doing a relative request. That part is working now

@paulirish
Copy link
Member Author

sweeeet

let's merge to master!

this is huge. congrats ryan!!! :D

@paulirish
Copy link
Member Author

cc @KuraFire @aFarkas @SlexAxton

Ryan got travis working and green!! Success!!

@ryanseddon
Copy link
Member

Not green yet! Caniuse test is still failing for some reason...

@ryanseddon
Copy link
Member

Aw yeah we have a passing build! I used the filter=!caniuse.com param to filter out the caniuse stuff since we don't really need to test that in ci.

@ryanseddon
Copy link
Member

Sexy time! We have travis-ci in master!

@SlexAxton
Copy link
Member

Wooooooooooooooo
On Mar 30, 2012 7:33 PM, "Ryan Seddon" <
reply@reply.github.com>
wrote:

Sexy time! We have travis-ci in master!


Reply to this email directly or view it on GitHub:
#490 (comment)

@paulirish
Copy link
Member Author

omg hot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants