New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update html5shiv to something post 3.4 #534

Closed
BigBlueHat opened this Issue Mar 27, 2012 · 16 comments

Comments

Projects
None yet
@BigBlueHat

I'm not sure how tied together html5shiv and Modernizr releases are, but there's a fairly critical bug in html5shiv 3.4 (included in Modernizr 2.5.3):
aFarkas/html5shiv#54

I ran into it via using .show() on

tags in jQuery and having them display:inline rather than the expected display:block.

I realize this would likely happen in "due course," but I wanted to highlight it in case the next Modernizr came out before the next html5shiv.

Thanks.

@tonytopper

This comment has been minimized.

Show comment
Hide comment
@tonytopper

tonytopper Mar 28, 2012

The outdated shiv in modernizr break cufón in IE8 on Windows XP. At least that's what I've gathered from the dev over at, sorccu/cufon#239

FWIW, I get weird double lettering, http://imagebin.org/205603

The outdated shiv in modernizr break cufón in IE8 on Windows XP. At least that's what I've gathered from the dev over at, sorccu/cufon#239

FWIW, I get weird double lettering, http://imagebin.org/205603

@sorccu

This comment has been minimized.

Show comment
Hide comment
@sorccu

sorccu Mar 29, 2012

Would need at least r28 (vs r26 for 3.4) to get Cufón working again:

http://code.google.com/p/html5shiv/source/list

Note that even though the issue manifests in Cufón, it quite likely breaks other things too.

sorccu commented Mar 29, 2012

Would need at least r28 (vs r26 for 3.4) to get Cufón working again:

http://code.google.com/p/html5shiv/source/list

Note that even though the issue manifests in Cufón, it quite likely breaks other things too.

@ringerce

This comment has been minimized.

Show comment
Hide comment
@ringerce

ringerce Mar 30, 2012

I haven't seen this issue addressed yet in the repo but you can grab an the latest version of Modernizr (2.5.3) with the current html5shiv 3.4 (R29) which address the issue with Cufón here:

http://scripts.whitesharkcreations.com/modernizr-2.5.3.min.js

I haven't seen this issue addressed yet in the repo but you can grab an the latest version of Modernizr (2.5.3) with the current html5shiv 3.4 (R29) which address the issue with Cufón here:

http://scripts.whitesharkcreations.com/modernizr-2.5.3.min.js

@brgrz

This comment has been minimized.

Show comment
Hide comment
@brgrz

brgrz Apr 4, 2012

No it doesn't, I still have the same issue as described here with Modernizr 2.5.3

sorccu/cufon#234

brgrz commented Apr 4, 2012

No it doesn't, I still have the same issue as described here with Modernizr 2.5.3

sorccu/cufon#234

@aFarkas

This comment has been minimized.

Show comment
Hide comment
@aFarkas

aFarkas Apr 4, 2012

Member

There were two commits after the 3.4 releasse of html5shiv addressing this issue (commit1 and commit2).

@jonathantneal is currently reviewing/testing the html5shiv code, so that we can release html5shiv 3.5 soon. As soon as this happens, I will update the Modernizr code.

The best way you can currently deal with this issue, is to build your Modernizr version without html5shiv and take the current html5shiv

Member

aFarkas commented Apr 4, 2012

There were two commits after the 3.4 releasse of html5shiv addressing this issue (commit1 and commit2).

@jonathantneal is currently reviewing/testing the html5shiv code, so that we can release html5shiv 3.5 soon. As soon as this happens, I will update the Modernizr code.

The best way you can currently deal with this issue, is to build your Modernizr version without html5shiv and take the current html5shiv

@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Apr 15, 2012

Member

ping @jonathantneal . we good?

Member

paulirish commented Apr 15, 2012

ping @jonathantneal . we good?

@ringerce

This comment has been minimized.

Show comment
Hide comment
@ringerce

ringerce Apr 16, 2012

@mhrovatic Are you saying the modified script I posted isn't working for u ? It includes html5shiv 3.4 (R29) which fixes the problem. It works fine on two sites I published recently.

@mhrovatic Are you saying the modified script I posted isn't working for u ? It includes html5shiv 3.4 (R29) which fixes the problem. It works fine on two sites I published recently.

@jonathantneal

This comment has been minimized.

Show comment
Hide comment
@jonathantneal

jonathantneal Apr 16, 2012

re: @paulirish - yea we are good. @jdalton did an awesome job jumping in with all of his enhancements. I just needed a chance to look over the code, as I had promised @aFarkas. We are good!

re: @paulirish - yea we are good. @jdalton did an awesome job jumping in with all of his enhancements. I just needed a chance to look over the code, as I had promised @aFarkas. We are good!

@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Apr 17, 2012

Member

Cool. @aFarkas plz bring the party over :D

Member

paulirish commented Apr 17, 2012

Cool. @aFarkas plz bring the party over :D

@aFarkas

This comment has been minimized.

Show comment
Hide comment
@aFarkas

aFarkas Apr 17, 2012

Member

@paulirish

Yeah just some final tests :-). Hope I can do this in 10hours.

Member

aFarkas commented Apr 17, 2012

@paulirish

Yeah just some final tests :-). Hope I can do this in 10hours.

@aFarkas

This comment has been minimized.

Show comment
Hide comment
@aFarkas

aFarkas Apr 18, 2012

Member

Just updated Modernizr with the new html5shiv, forgot to link the commit with this issue

Member

aFarkas commented Apr 18, 2012

Just updated Modernizr with the new html5shiv, forgot to link the commit with this issue

@aFarkas aFarkas closed this Apr 18, 2012

@BigBlueHat

This comment has been minimized.

Show comment
Hide comment
@BigBlueHat

BigBlueHat Apr 18, 2012

Thanks @aFarkas and everyone else involved! It'll save future generations much angst. ;)

Keep up the greatness.

Thanks @aFarkas and everyone else involved! It'll save future generations much angst. ;)

Keep up the greatness.

@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Apr 18, 2012

Member

woohoo @aFarkas

awesome

Member

paulirish commented Apr 18, 2012

woohoo @aFarkas

awesome

@hous

This comment has been minimized.

Show comment
Hide comment
@hous

hous May 4, 2012

Thanks for this fix! Any news on when this will be available in a production release of Modernizr (2.5.4?)

hous commented May 4, 2012

Thanks for this fix! Any news on when this will be available in a production release of Modernizr (2.5.4?)

@miketierney

This comment has been minimized.

Show comment
Hide comment
@miketierney

miketierney Jun 6, 2012

@paulirish or @aFarkas - any updates on when this will get incorporated into the production release?

@paulirish or @aFarkas - any updates on when this will get incorporated into the production release?

@compsedesigns

This comment has been minimized.

Show comment
Hide comment
@compsedesigns

compsedesigns Nov 6, 2012

@ringerce Your solution worked for me. That was easy. Thanks man!!!

@ringerce Your solution worked for me. That was easy. Thanks man!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment