Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update html5shiv to something post 3.4 #534

Closed
BigBlueHat opened this issue Mar 27, 2012 · 16 comments
Closed

update html5shiv to something post 3.4 #534

BigBlueHat opened this issue Mar 27, 2012 · 16 comments

Comments

@BigBlueHat
Copy link

@BigBlueHat BigBlueHat commented Mar 27, 2012

I'm not sure how tied together html5shiv and Modernizr releases are, but there's a fairly critical bug in html5shiv 3.4 (included in Modernizr 2.5.3):
aFarkas/html5shiv#54

I ran into it via using .show() on

tags in jQuery and having them display:inline rather than the expected display:block.

I realize this would likely happen in "due course," but I wanted to highlight it in case the next Modernizr came out before the next html5shiv.

Thanks.

@tonytopper
Copy link

@tonytopper tonytopper commented Mar 28, 2012

The outdated shiv in modernizr break cufón in IE8 on Windows XP. At least that's what I've gathered from the dev over at, sorccu/cufon#239

FWIW, I get weird double lettering, http://imagebin.org/205603

@sorccu
Copy link

@sorccu sorccu commented Mar 29, 2012

Would need at least r28 (vs r26 for 3.4) to get Cufón working again:

http://code.google.com/p/html5shiv/source/list

Note that even though the issue manifests in Cufón, it quite likely breaks other things too.

@ringerce
Copy link

@ringerce ringerce commented Mar 30, 2012

I haven't seen this issue addressed yet in the repo but you can grab an the latest version of Modernizr (2.5.3) with the current html5shiv 3.4 (R29) which address the issue with Cufón here:

http://scripts.whitesharkcreations.com/modernizr-2.5.3.min.js

@brgrz
Copy link

@brgrz brgrz commented Apr 4, 2012

No it doesn't, I still have the same issue as described here with Modernizr 2.5.3

sorccu/cufon#234

@aFarkas
Copy link
Member

@aFarkas aFarkas commented Apr 4, 2012

There were two commits after the 3.4 releasse of html5shiv addressing this issue (commit1 and commit2).

@jonathantneal is currently reviewing/testing the html5shiv code, so that we can release html5shiv 3.5 soon. As soon as this happens, I will update the Modernizr code.

The best way you can currently deal with this issue, is to build your Modernizr version without html5shiv and take the current html5shiv

@paulirish
Copy link
Member

@paulirish paulirish commented Apr 15, 2012

ping @jonathantneal . we good?

@ringerce
Copy link

@ringerce ringerce commented Apr 16, 2012

@mhrovatic Are you saying the modified script I posted isn't working for u ? It includes html5shiv 3.4 (R29) which fixes the problem. It works fine on two sites I published recently.

@jonathantneal
Copy link

@jonathantneal jonathantneal commented Apr 16, 2012

re: @paulirish - yea we are good. @jdalton did an awesome job jumping in with all of his enhancements. I just needed a chance to look over the code, as I had promised @aFarkas. We are good!

@paulirish
Copy link
Member

@paulirish paulirish commented Apr 17, 2012

Cool. @aFarkas plz bring the party over :D

@aFarkas
Copy link
Member

@aFarkas aFarkas commented Apr 17, 2012

@paulirish

Yeah just some final tests :-). Hope I can do this in 10hours.

@aFarkas
Copy link
Member

@aFarkas aFarkas commented Apr 18, 2012

Just updated Modernizr with the new html5shiv, forgot to link the commit with this issue

@aFarkas aFarkas closed this Apr 18, 2012
@BigBlueHat
Copy link
Author

@BigBlueHat BigBlueHat commented Apr 18, 2012

Thanks @aFarkas and everyone else involved! It'll save future generations much angst. ;)

Keep up the greatness.

@paulirish
Copy link
Member

@paulirish paulirish commented Apr 18, 2012

woohoo @aFarkas

awesome

@hous
Copy link

@hous hous commented May 4, 2012

Thanks for this fix! Any news on when this will be available in a production release of Modernizr (2.5.4?)

@miketierney
Copy link

@miketierney miketierney commented Jun 6, 2012

@paulirish or @aFarkas - any updates on when this will get incorporated into the production release?

@compsedesigns
Copy link

@compsedesigns compsedesigns commented Nov 6, 2012

@ringerce Your solution worked for me. That was easy. Thanks man!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.