-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
viewport units test #572
Comments
Yay. There is a real use-case I think especially now that it's shipping in Chrome 20 & IE 10. If support, use. |
IE9 and maybe 10 interpret 1vw as the full width and not 1/100th of the width. |
It was fixed in 10, in my testing. This is kind of a disaster though. Maybe Modernizr should just report no support for IE 9? Or would you do tweener/broken support like .viewportunits-100x |
+1 for reporting no support in IE 9, at least initially. |
@chriscoyier yeah I reckon just say no support for IE9 since it's a broken implementation anyway. Your proposed test will fail in IE9 so that should be fine. I modified my testcase based of your idea to test for 50vw width as it would false positive in Firefox doing 100vw as the div it injected would naturally be the full window width too. http://jsfiddle.net/ryanseddon/x4jA9/12/ This is false in IE9 and true in Chrome 20 and IE10 |
@ryanseddon if window.innerWidth is odd it won't work because getComputedStyle(elem, null)['width'] is rounded down. This might be better: http://jsfiddle.net/FWeinb/etnYC/ (Tested in Chrome 20) |
@FWeinb is anything changed I don't see any difference in the link? |
@ryanseddon Sorry I didn't saved it. I wrapped the window.innerWidth/2 with parseInt() to equally round it down. |
Ok awesome, does someone want to put a pull request together? |
@sguolin want to take a shot at the PR for this? |
CSS Relative Units (vw, vh, vmin, vmax) - Re: Issue #572
Fixed in #638 |
CSS Relative Units (vw, vh, vmin, vmax) - Re: Issue Modernizr#572
via @chriscoyier
basicallly
100vw == window.width
test to be written for real.
The text was updated successfully, but these errors were encountered: