Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@supports test #648

Closed
ryanseddon opened this issue Aug 7, 2012 · 4 comments
Closed

@supports test #648

ryanseddon opened this issue Aug 7, 2012 · 4 comments

Comments

@ryanseddon
Copy link
Member

@ryanseddon ryanseddon commented Aug 7, 2012

Breaking this out of the @Viewport test #604.

http://jsfiddle.net/ryanseddon/zusu5/2/

Really easy detect by looking for "CSSSupportsRule" in window. I think that's good enough to push a plugin now.

Objections?

@paulirish
Copy link
Member

@paulirish paulirish commented Aug 7, 2012

SGTM.

can you doublecheck the webkit patch to make sure it adds this item to the
CSSOM?

@ryanseddon
Copy link
Member Author

@ryanseddon ryanseddon commented Aug 8, 2012

I'm making an assumption and it's not clear in the patch (though it looks like the CSSGrammar.y file might be responsible for that?) if it is in there but they do expose every other At-Rule on the window object. I got the latest nightly for windows and it's not in there yet.

@paulirish
Copy link
Member

@paulirish paulirish commented Aug 8, 2012

Well, I'm not sure about webkit either. It doesnt look like it exposes this, but it certainly should..

GOod to go for now and we'll keep an eye on this

@ryanseddon
Copy link
Member Author

@ryanseddon ryanseddon commented Aug 9, 2012

Just for reference there is talk on the www-style mailing list of introducing a CSS global where things like supports will live under.

CSS.supports()

I'll push the current detect real soon.

@ryanseddon ryanseddon closed this in ef1a856 Aug 9, 2012
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
LaurentBarbareau added a commit to LaurentBarbareau/Modernizr that referenced this issue Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.