rename Modernizr.input to Modernizr.inputattr, inputtypes => inputtype #710

Closed
paulirish opened this Issue Sep 26, 2012 · 5 comments

Projects

None yet

5 participants

@paulirish
Modernizr member

Tell me if you think this makes any sense.

Currently:

  • Modernizr.input.max
  • Modernizr.input.autofocus
  • Modernizr.inputtypes.date

Proposed:

  • Modernizr.inputattr.max
  • Modernizr.inputattr.autofocus
  • Modernizr.inputtype.date

It seems clearer to me, but its not like we've gotten user feedback on this. :|

@KuraFire
Modernizr member

It is clearer, but if we're to change it we'll need to keep the current implementation aliased for quite some time, as those APIs have been around since day 1, over three years ago. Also, I too have never really seen anyone give any feedback—positive or negative—over those two APIs.

I don't particularly care strongly either way in this (keep or change), but I'm curious: do we know of any polyfills/shims/plugins that deal with input attributes and would break once the alias stops working?

Lastly, If we do this change, I propose this:

3.0 do the change, alias old syntax, announce future plans
3.1 still alias but start triggering a console message/warning when using the aliased version
3.2 stop aliasing the old syntax

Where 3.1 and 3.2 are flexible, for whatever medium version comes after at least a couple of months of heads-up time for the announcement + alias.

@jokeyrhyme

There are other HTML5 attributes that aren't specific to input fields, like hidden, etc:
http://developers.whatwg.org/elements.html#global-attributes
Does this make Modernizr.attr more appropriate than Modernizr.inputattr?

@sindresorhus
Modernizr member

Whatever we can do to improve the API and make it more succinct, but of course needs a deprecation plan like Faruk has written above.

@stucox
Modernizr member

Ping.

I propose we leave this as is. Maintenance pain for little gain IMO.

@paulirish
Modernizr member

OK. let's leave as is. I don't think this idea came from user requests anyhow.

@paulirish paulirish closed this Apr 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment