Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

IE8 and Modernizr.load: Object doesn't support this property or method? #729

Closed
brandondurham opened this Issue Oct 15, 2012 · 26 comments

Comments

Projects
None yet
10 participants

I'm using Modernizr 2.6.2 on a site in development and experiencing a frustrating error in IE8. I'm loading Modernizr in the head of the document. Then I'm loading a base.js file at the bottom of the page, just before the closing body tag. In that base.js file I have the following code:

/**
 *  Non-jQuery hasClass function for checking the existence of
 *  class names on elements.
 *  @param {string} scripts The string of scripts to check
 *  @param {string} cls The class name we're looking for
 *  @return {boolean} True or false
 */
/*
function hasClass(scripts, cls) {
    var r = new RegExp('\\b' + cls + '\\b');
    return r.test(scripts);
}*/


/**
 *  Get ID from <body> tag
 */
function matchBodyID(match) {
    return match.toLowerCase() === document.body.id.toLowerCase();
}


/**
 *  Check to see if the body tag has a "data-scripts" attribute.
 *  If true, collect the contents. If false, set to false.
 */
// var dataScripts = document.body.getAttribute("data-scripts") || false;


/**
 *  Variables must be defined before we can use them.
 */
var Modernizr = Modernizr || {},
    ScaleText = ScaleText || {};


/*
 *  Using Modernizr.load, we can run our tests to see
 *  which features are available to us and load our
 *  polyfills to handle those that aren't
 */
var timestamp = new Date().getTime();
Modernizr.load([
    {
        load: [
            '//ajax.googleapis.com/ajax/libs/jquery/1.7.1/jquery.js',
            'js/plugins/image-array-ck.js?t=' + timestamp,
            'js/plugins/jquery.debouncedresize-ck.js',
            'js/plugins/menu-ck.js?t=' + timestamp
        ],
        complete: function () {
            if (!window.jQuery) {
                Modernizr.load('js/vendor/jquery-1.8.1.min.js');
            }
            ScaleText.invoke();
            $("#skip-to-content").bind("click.menu", function (event) {
                event.preventDefault();
                var $this = $(this),
                $par = $($this.parent());
                $par.toggleClass("open");
            });
        }
    }, {
        test: matchBodyID('home') || matchBodyID('department'),
        yep: [
            'js/plugins/spin.min.js',
            'js/slideshow-ck.js',
            'css/royalslider/royalslider.css',
            'css/royalslider/rs-minimal-white.css',
            'js/plugins/tabs-ck.js?t=' + timestamp,
            'js/plugins/underscore-min.js'
        ]
    }, {
        test: matchBodyID('interior'),
        yep: [
            'js/plugins/spin.min.js',
            'js/plugins/tabs-ck.js?t=' + timestamp,
            // 'js/plugins/menu-ck.js?t=' + timestamp,
            'js/plugins/underscore-min.js'
        ]
    },
    // Check for iOS
    {
        test: Modernizr.appleios,
        yep: [
            'js/plugins/ios-ck.js'
        ]
    },
    // Functional polyfills
    {
        test: Modernizr.flexbox,
        nope: ['js/polyfills/flexie.js']
    }
]);




/*
 *  ScaleText
 *  An attempt to create a custom type scaler for
 *  large type that needs to scale to fit its parent
 */
ScaleText = {

    invoke: function () {
        $(".scalable").each(function (index, element) {
            var $parent = $(element),
                $wrapper = ScaleText.wrapIt($parent.first("div"));

            $parent.css({
                "overflow": "hidden",
                "opacity": 0
            });
            $wrapper.css({
                "-webkit-transform-origin": "left top",
                "-moz-transform-origin": "left top",
                "-ms-transform-origin": "left top",
                "-o-transform-origin": "left top",
                "transform-origin": "left top"
            });
            ScaleText.checkSize($parent, $wrapper);

            jQuery(window).on("debouncedresize.ScaleText", function () {
                ScaleText.checkSize($parent, $wrapper);
            });
        });
    },

    checkSize: function ($parent, $wrapper) {
        var scrollWidth = $parent[0].scrollWidth,
            width = $parent.width(),
            scrollHeight = $parent[0].scrollHeight,
            height = $parent.height(),
            ratio, wRatio, hRatio;

        wRatio = width / scrollWidth;
        hRatio = height / scrollHeight;
        ratio = (wRatio < hRatio) ? wRatio : hRatio;

        $wrapper.css({
            "-webkit-transform": "scale(" + ratio + ")",
            "-moz-transform": "scale(" + ratio + ")",
            "-ms-transform": "scale(" + ratio + ")",
            "-o-transform": "scale(" + ratio + ")",
            "transform": "scale(" + ratio + ")"
        });
        $parent.css({
            "opacity": 1
        });
    },

    wrapIt: function (element) {
        var content = $(element).html(),
            $wrapper = $("<div>" + content + "</div>");
        $(element).empty().append($wrapper);
        return $wrapper;
    }

};

For some reason IE8 is completely choking at the Modernizr.load block, saying only Object doesn't support this property or method. Screenshot attached.

Ideas around why this might be happening?

Screenshot of IE console: http://cloud.smallparade.com/KATM

I should mention I'm using a custom build of Modernizr: http://www.hastebin.com/fitaqireha.coffee

Owner

SlexAxton commented Oct 15, 2012

Does Modernizr.load exist, or does the || {} code win?

I threw an alert in there before the || {} and the alert itself is now throwing the error.

alert(Modernizr.load);
var Modernizr = Modernizr || {},
    ScaleText = ScaleText || {};
alert(Modernizr.load);
Owner

SlexAxton commented Oct 15, 2012

well, you're not calling it. what is inside the alert? [object function] or undefined or something different?

SCRIPT5007: Unable to get value of the property 'load': object is null or undefined

Owner

SlexAxton commented Oct 15, 2012

So you either didn't build load into the build, or Modernizr isn't loaded by that point.

load is in there. I'm using it in every other browser and IE9. I used to have a setInterval on there to ensure it was loaded. I'll try that quickly and see if it triggers in <IE9.

Owner

SlexAxton commented Oct 15, 2012

Are you loading it asynchronously or something? Modernizr works much better if it's included synchronously in the head. Otherwise you get flashes of bad state.

It's in the head. Here's the current code:

<!DOCTYPE html>
<!--[if lt IE 7]><html class="no-js lt-ie9 lt-ie8 lt-ie7"><![endif]-->
<!--[if IE 7]><html class="no-js lt-ie9 lt-ie8"><![endif]-->
<!--[if IE 8]><html class="no-js lt-ie9"><![endif]-->
<!--[if gt IE 8]><!--><html class="no-js"><!--<![endif]-->
    <head>
        <meta charset="utf-8">
        <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
        <title>CED &mdash; Final Templates</title>
        <meta name="description" content="">
        <meta name="viewport" content="width=device-width">
        <link rel="stylesheet" href="css/base.css">
        <link rel="stylesheet" href="css/home.css">
        <script src="js/vendor/modernizr-2.6.0-ck.js"></script>
    </head>
    <body id="home">
        <!--[if lt IE 7]><p class="chromeframe">You are using an outdated browser. <a href="http://browsehappy.com/">Upgrade your browser today</a> or <a href="http://www.google.com/chromeframe/?redirect=true">install Google Chrome Frame</a> to better experience this site.</p><![endif]-->

        <? include "_supernav.php"; ?>

        <div id="site-wrapper">
            <section id="header-and-features">
                <header class="site-header" id="main-header">
                    <div id="header-graphic" data-image-source="logo" data-image-array="logo-bg-a.png|logo-bg-b.png|logo-bg-c.png|logo-bg-d.png|logo-bg-e.png|logo-bg-f.png">
                        <h1>University of California, Berkeley, College of Environmental Design</h1>
                    </div>
                    <nav id="main-navigation">
                        <h2><abbr title="College of Environmental Design">CED</abbr> Menu</h2>
                        <ul>
                            <li>
                                <div class="menu-content">
                                    <a href="#">About <abbr title="College of Environmental Design">CED</abbr></a>
                                    <ul>
                                        <li><a href="/">Vision &plus; Principles</a></li>
                                        <li><a href="/">Leadership</a></li>
                                        <li><a href="/">Faculty &plus; Staff</a></li>
                                        <li><a href="/">Diversity</a></li>
                                        <li><a href="/">Contact &plus; Visit</a></li>
                                        <li><a href="/">Jobs</a></li>
                                    </ul>
                                </div>
                            </li>
                            <li>
                                <div class="menu-content">
                                    <a href="#">Academics</a>
                                    <ul>
                                        <li><a href="/">Architecture</a></li>
                                        <li><a href="/">City &plus; Regional Planning</a></li>
                                        <li><a href="/">Landscape Architecture &plus; Environmental Planning</a></li>
                                        <li><a href="/">Urban Design</a></li>
                                        <li><a href="/">Summer Programs</a></li>
                                        <li><a href="/">Courses &plus; Workshops</a></li>
                                        <li><a href="/">Policies &plus; Procedures</a></li>
                                    </ul>
                                </div>
                            </li>
                            <li>
                                <div class="menu-content">
                                    <a href="#">Admissions</a>
                                    <ul>
                                        <li><a href="#">Undergraduate</a></li>
                                        <li><a href="#">Graduate</a></li>
                                        <li><a href="#">Tuition &plus; Fees</a></li>
                                        <li><a href="#">Financial Aid</a></li>
                                    </ul>
                                </div>
                            </li>
                            <li>
                                <div class="menu-content">
                                    <a href="#">Support <abbr title="College of Environmental Design">CED</abbr></a>
                                    <ul>
                                        <li><a href="#">Make a Gift</a></li>
                                        <li><a href="#">CED Fund &plus; Campaign</a></li>
                                        <li><a href="#">Faculty Support</a></li>
                                        <li><a href="#">Student Support</a></li>
                                        <li><a href="#">Wurster Society</a></li>
                                        <li><a href="#">Honor Roll</a></li>
                                    </ul>
                                </div>
                            </li>
                            <li>
                                <div class="menu-content">
                                    <a href="#">Partnerships</a>
                                    <ul>
                                        <li><a href="#">What We Do</a></li>
                                        <li><a href="#">Who We Work With</a></li>
                                        <li><a href="#">Why Work With Us?</a></li>
                                        <li><a href="#">Case Studies</a></li>
                                    </ul>
                                </div>
                            </li>
                            <li>
                                <div class="menu-content">
                                    <a href="#">Research</a>
                                    <ul>
                                        <li><a href="#">What We Do</a></li>
                                        <li><a href="#">CEDR</a></li>
                                        <li><a href="#">IURD</a></li>
                                        <li><a href="#">Faculty Research</a></li>
                                        <li><a href="#">Library &plus; Archives</a></li>
                                    </ul>
                                </div>
                            </li>
                            <li>
                                <div class="menu-content">
                                    <a href="#">Events&plus;Media</a>
                                    <ul>
                                        <li><a href="#">Calendar</a></li>
                                        <li><a href="#">News</a></li>
                                        <li><a href="#">Special Events</a></li>
                                        <li><a href="#">Exhibitions</a></li>
                                        <li><a href="#">Publications</a></li>
                                        <li><a href="#">Commencement</a></li>
                                    </ul>
                                </div>
                            </li>
                            <li>
                                <div class="menu-content">
                                    <a href="#">Wurster Life</a>
                                    <ul>
                                        <li><a href="#">Computing</a></li>
                                        <li><a href="#">Shop, Labs &plus; Garden</a></li>
                                        <li><a href="#">Facilities &plus; Services</a></li>
                                        <li><a href="#">Careers</a></li>
                                        <li><a href="#">Prizes &plus; Awards</a></li>
                                        <li><a href="#">Student Life</a></li>
                                        <li><a href="#">Faculty &plus; Staff Resources</a></li>
                                    </ul>
                                </div>
                            </li>
                        </ul>
                    </nav>
                </header>
                <div class="features">
                    <article class="major-article urban">
                        <figure class="royalslider rsMinW" id="feature-slideshow">
                            <div class="rsContent"><a class="rsImg" href="/images/slide-1.png">Image description</a></div>
                            <div class="rsContent"><a class="rsImg" data-rsVideo="http://www.youtube.com/watch?v=cGZki7_PjYE" href="/images/slide-2.jpg">Is it safe?</a></div>
                            <div class="rsContent"><a class="rsImg" data-rsVideo="http://www.youtube.com/watch?v=8jvb4vI_ISA" href="/images/slide-3.jpg">Is it safe?</a></div>
                            <div class="rsContent"><a class="rsImg" data-rsVideo="http://www.youtube.com/watch?v=mJHNPLJOS-Q" href="/images/slide-4.jpg">Is it safe?</a></div>
                        </figure>
                        <div class="article-content">
                            <header>
                                <h3><span class="tag-name">Tag One</span></h3>
                                <h2>Feature One</h2>
                            </header>
                            <p>Lorem ipsum aliqua mollit ad quis incididunt pariatur occaecat cupidatat et exercitation elit exercitation. </p>
                        </div>
                        <div class="article-content">
                            <header>
                                <h3><span class="tag-name">Tag Two</span></h3>
                                <h2>Feature Two</h2>
                            </header>
                            <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
                        </div>
                        <div class="article-content">
                            <header>
                                <h3><span class="tag-name">Tag Three</span></h3>
                                <h2>Feature Three</h2>
                            </header>
                            <p>Nothing to see here. Please move along. Nothing to see here. Please move along. Nothing to see here. Please move along. Nothing to see here. Please move along. Nothing to see here. Please move along. Nothing to see here. Please move along.</p>
                        </div>
                        <div class="article-content">
                            <header>
                                <h3><span class="tag-name">Tag Four</span></h3>
                                <h2>Feature Four</h2>
                            </header>
                            <p>Lorem ipsum fugiat nisi ad dolore quis cillum Duis in ullamco ullamco in ex non dolor dolore et mollit dolore sunt reprehenderit sed est in ea exercitation id voluptate ullamco.</p>
                        </div>
                    </article>
                    <div class="split-articles">
                        <article class="minor-article ced">
                            <figure>
                            <img src="images/holder-800x400.png">
                            </figure>
                            <div class="article-content">
                                <header>
                                    <h3><span class="tag-name">Tag Name</span></h3>
                                    <h2>Feature Title</h2>
                                </header>
                                <p>There is nothing to see here. Please move along. There is nothing to see here. Please move along.</p>
                            </div>
                        </article>
                        <article class="minor-article land">
                            <figure>
                            <img src="images/holder-800x400.png">
                            </figure>
                            <div class="article-content">
                                <header>
                                    <h3><span class="tag-name">Tag Name</span></h3>
                                    <h2>This Here is a Much Longer Feature Title</h2>
                                </header>
                                <p>Lorem ipsum tempor pariatur nulla dolore esse est adipisicing occaecat proident Ut pariatur est qui aliqua Duis consequat qui cillum proident labore in Excepteur adipisicing ut deserunt dolor consequat dolor aute sunt culpa veniam deserunt exercitation proident.</p>
                            </div>
                        </article> 
                    </div>
                </div> 
            </section>
            <section id="sidebar-right">
                <nav id="department-navigation">
                    <ul>
                        <li class="arch"><a href="#">Architecture</a></li>
                        <li class="city"><a href="#">City &plus; Regional Planning</a></li>
                        <li class="land"><a href="#">Landscape Architecture &plus; Environmental Planning</a></li>
                        <li class="urban"><a href="#">Urban Design</a></li>
                    </ul>
                </nav>
                <div class="features">
                    <article class="minor-article ced">
                        <figure>
                            <img src="images/holder-800x400.png">
                        </figure>
                        <div class="article-content">
                            <header>
                                <h3><span class="tag-name">Tag Name</span></h3>
                                <h2>Feature Title</h2>
                            </header>
                            <p>There is nothing to see here. Please move along. There is nothing to see here. Please move along.</p>
                        </div>
                    </article>
                    <article class="minor-article urban">
                        <figure>
                            <img src="images/holder-800x400.png">
                        </figure>
                        <div class="article-content">
                            <header>
                                <h3><span class="tag-name">Tag Name</span></h3>
                                <h2>This Here is a Much Longer Feature Title</h2>
                            </header>
                            <p>Lorem ipsum in exercitation cupidatat mollit labore nostrud deserunt labore est proident officia dolore irure deserunt sint cillum incididunt dolore aliquip aute ex consectetur proident enim eu dolore sint fugiat labore laborum incididunt officia anim laboris ullamco nostrud qui in laborum nostrud mollit dolore eu.</p>
                        </div>
                    </article>
                    <article class="minor-article city">
                        <figure>
                            <img src="images/holder-800x400.png">
                        </figure>
                        <div class="article-content">
                            <header>
                                <h3><span class="tag-name">Tag Name</span></h3>
                                <h2>This Here is a Much Longer Feature Title</h2>
                            </header>
                            <p>Lorem ipsum in dolor qui sed adipisicing adipisicing cillum qui incididunt irure nostrud et commodo Ut mollit qui dolore dolore cupidatat ut id laborum sunt commodo qui Excepteur consequat Ut esse ea irure sunt elit. </p>
                        </div>
                    </article>
                </div>
            </section>
            <section id="news-events-search">
                <nav id="news-events-search-navigation" data-tabbed data-collapsible="false" data-collapsed="false">
                    <ul>
                        <li class="events">
                            <a class="tab" data-relative-content="events-feed" href="#"><abbr title="College of Environmental Design">CED</abbr> Events</a>
                        </li>
                        <li class="news">
                            <a class="tab" href="#" data-relative-content="news-feed"><abbr title="College of Environmental Design">CED</abbr> News</a>
                        </li>
                        <li class="search">
                            <label for="search-field" class="tab" data-relative-content="search-feed">Search</label>
                            <input id="search-field" name="search-field" type="search" placeholder="Please type to search">
                            <button class="cancel">Close</button>
                        </li>
                    </ul>
                </nav>
                <div class="feed-results">
                    <div class="results" id="events-feed"></div>
                    <div class="results" id="news-feed"></div>
                    <div class="results" id="search-feed">
                        <ul>
                            <li>Use the form above to search the site.</li>
                        </ul>
                    </div>
                </div>
            </section>
        </div>

        <footer id="site-footer">
            <div class="logo">
                <header>
                    <a href="/" class="logo">University of California, Berkeley, College of Environmental Design</a>
                </header>
            </div>
            <div class="address">
                <div class="vcard">
                    <div class="org">College of Environmental Design<br>University of California, Berkeley</div>
                    <div class="adr">
                        <div class="street-address">230 Wurster Hall #1820</div>
                        <span class="locality">Berkeley</span>, <span class="region">CA</span> <span class="postal-code">94720&ndash;1820</span>
                    </div>
                </div>
            </div>
            <div class="departments">
                <nav class="footer-nav">
                    <ul>
                        <li><a href="#" class="arch">Architecture</a></li>
                        <li><a href="#" class="city">City &plus; Regional Planning</a></li>
                        <li><a href="#" class="land">Landscape Architecture &plus; Environmental Planning</a></li>
                        <li><a href="#" class="urban">Urban Design</a></li>
                    </ul>
                </nav>
            </div>
            <div class="contact">
                <nav>
                    <ul>
                        <li><a href="#">Contact Us</a></li>
                        <li><a href="#">Site Map</a></li>
                        <li><a href="#">Log In</a></li>
                        <li class="copyright">&copy; UC Regents. All rights reserved</li>
                    </ul>
                </nav>
            </div>
        </footer>

        <!-- Templates -->
        <? include "_templates.php"; ?>

        <script src="js/base.js?<?= time() ?>"></script>
        <script>
            var _gaq=[['_setAccount','UA-XXXXX-X'],['_trackPageview']];
            (function(d,t){var g=d.createElement(t),s=d.getElementsByTagName(t)[0];
            g.src=('https:'==location.protocol?'//ssl':'//www')+'.google-analytics.com/ga.js';
            s.parentNode.insertBefore(g,s)}(document,'script'));
        </script>

    </body>
</html>
Owner

SlexAxton commented Oct 15, 2012

If it's in the head and synchronous, then it must exist below. Can you post a working link to your build?

I can email or IM it to you. That work?

Emailed.

Hi guys. Did you work this one out? I've just found the same problem with pretty much the exact same setup and scenario.

Member

sindresorhus commented Jan 23, 2013

ping

I found calling window.Modernizr from the global scope solved the problem.

Owner

stucox commented Jan 24, 2013

Odd. But looks like we can put this down to a funny scoping thing with your specific use case. Thanks.

@stucox stucox closed this Jan 24, 2013

It was pretty basic, just calling Modernizr.load() from within a function. Without calling window.Modernizr.load(), IE threw the error, like it's not recognising the Modernizr variable

Owner

stucox commented Jan 24, 2013

Still doesn't sound like a Modernizr bug to me - surely Modernizr's either in scope or it isn't? Happy to reopen if you're convinced I'm wrong though.

Same problem here (IE8, IE9).

IE8 error message:

Message: Object doesn't support this property or method
Line: 4
Char: 8272
Code: 0
URI: http://PROJECT/js/dynamic/modernizr-2.6.2-min.js

Error link jumps to the following yepnope1.5.4 code position part in minified Modernizr code:

... CURSORHERE y[c].hasOwnProperty(d)&&y[c][d].onload()}}var j=j||B.errorTimeout,l= ...

After the error is dismissied, the UI tab script is loaded and everything works fine.

Calling function:

initTabs: function () {
    var $tabs = this.$ctx;
    $.log(Tc.Config.dependencyPath.plugin);
    Modernizr.load([
        {
            test: ($tabs.length > 0),
            yep: Tc.Config.dependencyPath.plugin + 'jquery.ui.tabs.min.js',
            complete: function (url, result, key) {
                // html5.shivMethods = false;
                $.log(url);
                $.log(result);
                $.log(key);
                $tabs.tabs();
            }
        }
    ]);
}

I do not know where I should look for more. If anybody has a clue ...

Thanks a lot.

Owner

stucox commented Feb 12, 2013

Re-opening - think we were mistaken before about exactly what the issue was. Thanks for the info @eduardseifert.

Looks like that's here: https://github.com/SlexAxton/yepnope.js/blob/master/yepnope.js#L215... any ideas @slexaxton?

@stucox stucox reopened this Feb 12, 2013

if developing with Visual Studio and use NuGet to download Modernizr it does NOT include the load method. If you do a custom download from Modernizr site make sure that Modernizr.Load is selected under the Extra section

Owner

stucox commented Apr 18, 2013

Thanks for the note @rrjamesjr.

I think we can track this against YepNope.js here: SlexAxton/yepnope.js#154

@stucox stucox closed this Apr 18, 2013

@ghing ghing added a commit to ghing/onboard_profile that referenced this issue Dec 31, 2013

@ghing ghing Add media query polyfill for IE8.
Use Respond.js (https://github.com/scottjehl/Respond) as a
polyfill for media queries in IE8.

I originally wanted to load the polyfill with Modernizr, but ran
into some issues with Modernizr.load() similar to the ones
described at Modernizr/Modernizr#729.
Since this is the only Polyfill we're using so far, and it
includes a check that short-circuits for browsers that support
media queries, we'll just include this script directly for now.

Note that Respond.js and other media query polyfills don't work
with stylesheets included via @import, so you need to enable
CSS aggregation to make this work.

Addresses #3551
6ffd823

@travisward travisward referenced this issue in AgriLife/College-2013 May 1, 2014

Open

Crashing IE8 on Win 7 #4

oising commented Dec 1, 2014

Just ran into this now, December 2014 -- the build in NuGet (as of this moment, 2.8.3) doesn't contain the load functionality. but why?

Owner

patrickkettner commented Dec 1, 2014

please read the above linked issue from yepnope

newpen commented Mar 3, 2015

I am experiencing the same issue. I have tried to include Modernizr.load on different places but it doesn't help...

newpen commented Mar 3, 2015

I discovered that it's not working whether i am on a second or third layer of my site. That is, it does not work when I am on www.domain.com/path/to/my.html but works on www.domain.com/my.html. I am sure the javascript files are correctly included in both cases.

Owner

patrickkettner commented Mar 3, 2015

@newpen that sounds like your load paths are not correct (perhaps you are using relative paths).

regardless, please open an issue on stackoverflow for this sort of problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment