New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csstransforms3d false negative in Webkit #740

Closed
simonschuh opened this Issue Nov 2, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@simonschuh

simonschuh commented Nov 2, 2012

I just had an issue with false negatives for 3D-transforms in all webkit-browsers.
Figured out that the problem was I added padding to all divs (with margin it's the same).
I guess the tests for offsets fail.
Here is a jsfiddle: http://jsfiddle.net/yGqxw/

So i don't know if it is a bug or maybe there is no other way to test for 3d transforms.
But it took me a while to figure out why the test stopped working.

@ryanseddon

This comment has been minimized.

Member

ryanseddon commented Nov 3, 2012

Good find, seems we'll need to reset the margin, padding and borders to mitigate this if Modernizr is loaded inside the body.

@ryanseddon ryanseddon closed this in d7c7393 Nov 3, 2012

SlexAxton added a commit to SlexAxton/Modernizr that referenced this issue Nov 5, 2012

Merge branch 'master' of github.com:Modernizr/Modernizr
* 'master' of github.com:Modernizr/Modernizr:
  Fixed false positive of 3d transforms if test element inherits margin, padding or border, fixes Modernizr#740
  Fix false negative in Android 4, fixes Modernizr#738
  Update feature-detects/exif-orientation.js
  Trim trailing whitespace and insert final newlines

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

Merge branch 'master' of github.com:Modernizr/Modernizr
* 'master' of github.com:Modernizr/Modernizr:
  Fixed false positive of 3d transforms if test element inherits margin, padding or border, fixes Modernizr#740
  Fix false negative in Android 4, fixes Modernizr#738
  Update feature-detects/exif-orientation.js
  Trim trailing whitespace and insert final newlines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment