Modernizr.csstransforms3d false for Chrome 23 #760

Closed
tricki opened this Issue Nov 30, 2012 · 3 comments

Comments

Projects
None yet
4 participants
@tricki

tricki commented Nov 30, 2012

Chrome Version: 23.0.1271.64 m

Example:
http://www.creativesandbox.com/guidebook

@Grhu

This comment has been minimized.

Show comment
Hide comment
@Grhu

Grhu Dec 6, 2012

For me it only happens when site is zoomed to 25%, 50%, 75%, 125% or 150%. Google Chrome 23.0.1271.95.

Grhu commented Dec 6, 2012

For me it only happens when site is zoomed to 25%, 50%, 75%, 125% or 150%. Google Chrome 23.0.1271.95.

stucox added a commit to stucox/Modernizr that referenced this issue Dec 30, 2012

@stucox

This comment has been minimized.

Show comment
Hide comment
@stucox

stucox Dec 30, 2012

Member

I only see this at non-unity zoom levels too. Looks like a rounding bug in Chrome? The style test resulted in the test element being 1px off the height it was supposed to be; changing the numbers slightly makes it work (as shown in the pull request above)

Chrome clearly still supports 3D transforms at other zoom levels, so I think working around this to consistently give a positive test result makes sense, even if it appears there are some slight inaccuracies when zoomed.

Member

stucox commented Dec 30, 2012

I only see this at non-unity zoom levels too. Looks like a rounding bug in Chrome? The style test resulted in the test element being 1px off the height it was supposed to be; changing the numbers slightly makes it work (as shown in the pull request above)

Chrome clearly still supports 3D transforms at other zoom levels, so I think working around this to consistently give a positive test result makes sense, even if it appears there are some slight inaccuracies when zoomed.

paulirish added a commit that referenced this issue Jan 7, 2013

Merge pull request #774 from stucox/760-csstransforms3d
Tweak to csstransforms3d test for issue #760
@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Jan 7, 2013

Member

fixed by #774

Member

paulirish commented Jan 7, 2013

fixed by #774

@paulirish paulirish closed this Jan 7, 2013

SlexAxton pushed a commit to SlexAxton/Modernizr that referenced this issue Feb 14, 2013

paulirish added a commit to SlexAxton/Modernizr that referenced this issue Feb 14, 2013

Merge pull request #774 from stucox/760-csstransforms3d
Tweak to csstransforms3d test for issue #760

SlexAxton added a commit to SlexAxton/Modernizr that referenced this issue Feb 23, 2013

Merge branch 'master' of github.com:Modernizr/Modernizr
* 'master' of github.com:Modernizr/Modernizr: (70 commits)
  Fixed a typo in `testMediaQuery()`
  Added wrapflow test, in AMD format - fixes #786
  Fixes missing brackets and removes unneeded "Pre 1.2" from the user agent regex ("webOS" already covers that).
  Corrected name for `touch` (to `touchevents`) in Modernizr-caniuse mapping
  Robustisize the binary WebSocket detect. Fixes #370
  Update detect for fullscreen api. Fixes #739
  Added DOM PointerEvents test as Modernizr.pointerevents
  Moved Modernizr.pointerevents -> Modernizr.csspointer events (API break...)
  Moved Modernizr.touch -> Modernizr.touchevents (kept an alias though)
  Matches #777 in v3 land.
  Matches #774 in v3 land.
  Matches #773 in v3 land.
  whitespace
  Adds 'peerconnection' feature detection, namespaces WebRTC features together
  Tweaked csstransforms3d style test numbers to work around rounding bug in Chrome 23.0 when zoomed (#760)
  Added fileinput test mobile UA blacklist for issue #772
  Added fileinput test mobile UA blacklist for issue #772
  adding docs from alex's email.
  whitespace
  SUPERSECRET MICROSOFT REQUESTED SENSORSHIP
  ...

SlexAxton added a commit to SlexAxton/Modernizr that referenced this issue Feb 23, 2013

Merge branch '3pre'
* 3pre: (58 commits)
  fill up metadata a bit more, a few new conventions
  Saving full dependecies into package.json
  Removing node_modules, adding in metadata reader, ignoring generated metadata
  remove the node modules via an ignore
  Corrected name for `touch` (to `touchevents`) in Modernizr-caniuse mapping
  Robustisize the binary WebSocket detect. Fixes #370
  Update detect for fullscreen api. Fixes #739
  Added DOM PointerEvents test as Modernizr.pointerevents
  Moved Modernizr.pointerevents -> Modernizr.csspointer events (API break...)
  Moved Modernizr.touch -> Modernizr.touchevents (kept an alias though)
  Matches #777 in v3 land.
  Matches #774 in v3 land.
  Matches #773 in v3 land.
  whitespace
  Adds 'peerconnection' feature detection, namespaces WebRTC features together
  Tweaked csstransforms3d style test numbers to work around rounding bug in Chrome 23.0 when zoomed (#760)
  Added fileinput test mobile UA blacklist for issue #772
  Added fileinput test mobile UA blacklist for issue #772
  adding docs from alex's email.
  whitespace
  ...

Conflicts:
	config-all.json
	feature-detects/css/animations.js
	feature-detects/forms/fileinput.js
	modular.html
	package.json

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

Merge pull request #774 from stucox/760-csstransforms3d
Tweak to csstransforms3d test for issue #760

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

Merge branch 'master' of github.com:Modernizr/Modernizr
* 'master' of github.com:Modernizr/Modernizr: (70 commits)
  Fixed a typo in `testMediaQuery()`
  Added wrapflow test, in AMD format - fixes #786
  Fixes missing brackets and removes unneeded "Pre 1.2" from the user agent regex ("webOS" already covers that).
  Corrected name for `touch` (to `touchevents`) in Modernizr-caniuse mapping
  Robustisize the binary WebSocket detect. Fixes #370
  Update detect for fullscreen api. Fixes #739
  Added DOM PointerEvents test as Modernizr.pointerevents
  Moved Modernizr.pointerevents -> Modernizr.csspointer events (API break...)
  Moved Modernizr.touch -> Modernizr.touchevents (kept an alias though)
  Matches #777 in v3 land.
  Matches #774 in v3 land.
  Matches #773 in v3 land.
  whitespace
  Adds 'peerconnection' feature detection, namespaces WebRTC features together
  Tweaked csstransforms3d style test numbers to work around rounding bug in Chrome 23.0 when zoomed (#760)
  Added fileinput test mobile UA blacklist for issue #772
  Added fileinput test mobile UA blacklist for issue #772
  adding docs from alex's email.
  whitespace
  SUPERSECRET MICROSOFT REQUESTED SENSORSHIP
  ...

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

Merge branch '3pre'
* 3pre: (58 commits)
  fill up metadata a bit more, a few new conventions
  Saving full dependecies into package.json
  Removing node_modules, adding in metadata reader, ignoring generated metadata
  remove the node modules via an ignore
  Corrected name for `touch` (to `touchevents`) in Modernizr-caniuse mapping
  Robustisize the binary WebSocket detect. Fixes #370
  Update detect for fullscreen api. Fixes #739
  Added DOM PointerEvents test as Modernizr.pointerevents
  Moved Modernizr.pointerevents -> Modernizr.csspointer events (API break...)
  Moved Modernizr.touch -> Modernizr.touchevents (kept an alias though)
  Matches #777 in v3 land.
  Matches #774 in v3 land.
  Matches #773 in v3 land.
  whitespace
  Adds 'peerconnection' feature detection, namespaces WebRTC features together
  Tweaked csstransforms3d style test numbers to work around rounding bug in Chrome 23.0 when zoomed (#760)
  Added fileinput test mobile UA blacklist for issue #772
  Added fileinput test mobile UA blacklist for issue #772
  adding docs from alex's email.
  whitespace
  ...

Conflicts:
	config-all.json
	feature-detects/css/animations.js
	feature-detects/forms/fileinput.js
	modular.html
	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment