New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`emoji` test breaks UTF-8 encoding in minified Production build #899

Closed
aarontgrogg opened this Issue Apr 10, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@aarontgrogg

http://modernizr.com/download/#-canvas-canvastext-emoji

When not minifying, the test includes the following line:
ctx.fillText('\ud83d\ude03', 0, 0); // "smiling face with open mouth" emoji

When minifying, the emoji is interpreted, so it appears in my IDE (Komodo) as the smiley face...

Atg

stucox added a commit to stucox/Modernizr that referenced this issue Apr 10, 2013

@stucox

This comment has been minimized.

Show comment
Hide comment
@stucox

stucox Apr 10, 2013

Member

@aarontgrogg - ^^ that seems to do it... any objections?

Member

stucox commented Apr 10, 2013

@aarontgrogg - ^^ that seems to do it... any objections?

@aarontgrogg

This comment has been minimized.

Show comment
Hide comment
@aarontgrogg

aarontgrogg Apr 10, 2013

Er, should? Assuming this hasn't been pushed to the live site yet, I'm still getting the resolved ASCII face there...

But, thanks!

Atg

Er, should? Assuming this hasn't been pushed to the live site yet, I'm still getting the resolved ASCII face there...

But, thanks!

Atg

@stucox

This comment has been minimized.

Show comment
Hide comment
@stucox

stucox Apr 10, 2013

Member

We won't be updating the live site again until we launch v3 because it's an entirely new build system; not sure when that will be just yet.

If you want a minified build with the emoji test right now, your best bet is probably to run the unminified build through Uglify yourself, with the --ascii option.

Member

stucox commented Apr 10, 2013

We won't be updating the live site again until we launch v3 because it's an entirely new build system; not sure when that will be just yet.

If you want a minified build with the emoji test right now, your best bet is probably to run the unminified build through Uglify yourself, with the --ascii option.

@aarontgrogg

This comment has been minimized.

Show comment
Hide comment
@aarontgrogg

aarontgrogg Apr 10, 2013

nah, just checking... :-)

cheers, and nice turn-around time!

Atg

Aaron T. Grogg
website: http://aarontgrogg.com/
email: aarontgrogg@gmail.com
twitter: @aarontgrogg
skype: aarontgrogg
aim: äarontgrogg

On Wed, Apr 10, 2013 at 2:30 PM, Stu Cox notifications@github.com wrote:

We won't be updating the live site again until we launch v3 because it's
an entirely new build system; not sure when that will be just yet.

If you want a minified build with the emoji test right now, your best bet
is probably to run the unminified build through Uglify yourself, with the
--ascii option.


Reply to this email directly or view it on GitHubhttps://github.com/Modernizr/Modernizr/issues/899#issuecomment-16171005
.

nah, just checking... :-)

cheers, and nice turn-around time!

Atg

Aaron T. Grogg
website: http://aarontgrogg.com/
email: aarontgrogg@gmail.com
twitter: @aarontgrogg
skype: aarontgrogg
aim: äarontgrogg

On Wed, Apr 10, 2013 at 2:30 PM, Stu Cox notifications@github.com wrote:

We won't be updating the live site again until we launch v3 because it's
an entirely new build system; not sure when that will be just yet.

If you want a minified build with the emoji test right now, your best bet
is probably to run the unminified build through Uglify yourself, with the
--ascii option.


Reply to this email directly or view it on GitHubhttps://github.com/Modernizr/Modernizr/issues/899#issuecomment-16171005
.

stucox pushed a commit that referenced this issue Apr 17, 2013

Stu Cox
Merge pull request #900 from stucox/master
Set ASCII-only option in Uglify - fixes #899

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015

Stu Cox
Merge pull request #900 from stucox/master
Set ASCII-only option in Uglify - fixes #899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment