Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add XHR `responseType` tests #1006
Gotta love unit tests. Amended the commit, wrapping the
Personally (and @ryanseddon has said this in the past too), I prefer separate tests to using subproperties – they're easier to work with, fit better when using classes etc. But maybe this is a valid application for subproperties.
Even if sticking with multiple tests, we could reduce the duplication:
Thanks for the feedback!
@stucox I went with separate tests that don’t depend on each other because these tests are very specific. If you ever need them, chances are you only need one of them, but not more than that. Let’s say you use
TL;DR -1 to introducing an AMD dependency on