Remove audiodata test #1019

Merged
merged 1 commit into from Aug 19, 2013

Projects

None yet

3 participants

@patrickkettner
Member

Originally noted in #721, the current test only checks for audio
elements on the window. This results in true in pretty much all
browsers. Audio data only exists in FF as a depricated API. The test is
currently broken. I created a new pull since the old one (#721) was old
and out of date.

Removing the test, since it is depreciated and inaccurate.

@ryanseddon
Member

Should we even bother with this test? It's been deprecated in favour of the Web Audio API. Thoughts?

@patrickkettner
Member

Since it is still supported by a shipping browser, I think it makes sense to include it. We decided to include a text-overflow test recently (#188), despite the fact that FF was the only lacking browser and has supported it since 3.6 (which was EOLed over a year ago). Obviously its likely someone will need ellipsis more than they will need Audio Data, but I am not clear as to what the "meh" line is for our support...

@stucox
Member
stucox commented Aug 19, 2013

Modernizr should be encouraging current standards – so I'd be in favour of dropping it. Given that the detect doesn't work, I'd hope very few projects are using it. v3 is a good chance to do this, but we'd have to ensure we include it in the release notes.

@patrickkettner patrickkettner Remove audio data test
Originally noted in #721, the current test only checks for audio
elements on the window. This results in true in pretty much all
browsers. Audio data only exists in FF as a depricated API. The test is
currently broken. I created a new pull since the old one (#721) was old
and out of date.
53424e1
@patrickkettner
Member

Sounds good to me.

@stucox
Member
stucox commented Aug 19, 2013

Great, thanks. I've updated the release notes too.

@stucox stucox merged commit 26f64a2 into Modernizr:master Aug 19, 2013

1 check passed

default The Travis CI build passed
Details
@stucox stucox referenced this pull request Aug 19, 2013
Closed

v3.0 release notes #805

@patrickkettner
Member

You wanna close out #721 as well?

@patrickkettner patrickkettner deleted the patrickkettner:audio-data-update branch Aug 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment