New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deleteDatabase as a subprop detect to indexedDB. #1238

Merged
merged 1 commit into from Mar 12, 2014

Conversation

Projects
None yet
2 participants
@patrickkettner
Member

patrickkettner commented Feb 28, 2014

fixes #1227, also fixes #979

@@ -24,6 +24,7 @@ define(['Modernizr', 'addTest', 'prefixed', 'test/indexeddb'], function( Moderni
var db;
if (!Modernizr.indexeddb) return false;
if (!Modernizr.indexeddb.deleteDatabase) return false;

This comment has been minimized.

@stucox

stucox Mar 4, 2014

Member

Maybe tidier as if (!(Modernizr.indexeddb && Modernizr.indexeddb.deleteDatabase)) { ... } ?

This comment has been minimized.

@patrickkettner
db.close();
indexeddb.deleteDatabase(dbname);
}
if (!(Modernizr.indexeddb && Modernizr.indexeddb.deleteDatabase)) {

This comment has been minimized.

@stucox

stucox Mar 4, 2014

Member

Isn’t the logic the wrong way round now? I was just expecting this:

if (!(Modernizr.indexddb && Modernizr.indexeddb.deleteDatabase)) {
  return false;
}

// Then the rest
@patrickkettner

This comment has been minimized.

Member

patrickkettner commented Mar 9, 2014

thanks again for the sanity check, @stucox - good to go?

@patrickkettner

This comment has been minimized.

Member

patrickkettner commented Mar 12, 2014

ping @stucox

@stucox

This comment has been minimized.

Member

stucox commented Mar 12, 2014

Yep yep.

stucox pushed a commit that referenced this pull request Mar 12, 2014

Stu Cox
Merge pull request #1238 from patrickkettner/deletedb
add deleteDatabase as a subprop detect to indexedDB.

@stucox stucox merged commit 1a7d746 into Modernizr:master Mar 12, 2014

1 check passed

default The Travis CI build passed
Details

@patrickkettner patrickkettner deleted the patrickkettner:deletedb branch Mar 12, 2014

@stucox stucox referenced this pull request May 21, 2014

Closed

v3.0 release notes #805

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015

Stu Cox
Merge pull request Modernizr#1238 from patrickkettner/deletedb
add deleteDatabase as a subprop detect to indexedDB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment