New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Modernizr.load - fixes #1182 #1241

Merged
merged 1 commit into from Mar 2, 2014

Conversation

Projects
None yet
2 participants
@patrickkettner
Member

patrickkettner commented Mar 1, 2014

No description provided.

src/load.js Outdated
}
}
ModernizrProto.load = function() {
log('Modenizr.load has been removed. Please upgrade your code to use yepnope directly');

This comment has been minimized.

@stucox

stucox Mar 1, 2014

Member

Can we make this a bit friendlier / more helpful?

yepnope.js (aka Modernizr.load) is no longer included as part of Modernizr. Get it from http://yepnopejs.com and update your code to use it directly.
See http://github.com/Modernizr/Modernizr/issues/1182 for more information.

Also, I thought the plan was to only error if yepnope isn’t present? (and warn if it is – see below)

This comment has been minimized.

@patrickkettner

patrickkettner Mar 1, 2014

Member

Can we make this a bit friendlier / more helpful?

yep! intentionally left poorly worded to make sure we talk about it here

Also, I thought the plan was to only error if yepnope isn’t present? (and warn if it is – see below)

my mistake. updating...

src/load.js Outdated
}
}
if ('yepnope' in window) {
window.yepnope.apply(window, [].slice.call(arguments,0));

This comment has been minimized.

@stucox

stucox Mar 1, 2014

Member

We agreed to warn if yepnope is present – could be something like:

yepnope.js (aka Modernizr.load) is no longer included as part of Modernizr. yepnope appears to be available on the page, so we’ll use it to handle this call to Modernizr.load, but please update your code to use yepnope directly.
See http://github.com/Modernizr/Modernizr/issues/1182 for more information.
@patrickkettner

This comment has been minimized.

Member

patrickkettner commented Mar 1, 2014

updated

@stucox

This comment has been minimized.

Member

stucox commented Mar 2, 2014

LGTM! 👍

stucox pushed a commit that referenced this pull request Mar 2, 2014

Stu Cox
Merge pull request #1241 from patrickkettner/unload
remove Modernizr.load - fixes #1182

@stucox stucox merged commit 5477732 into Modernizr:master Mar 2, 2014

1 check passed

default The Travis CI build passed
Details

@patrickkettner patrickkettner deleted the patrickkettner:unload branch Mar 2, 2014

@stucox stucox referenced this pull request Mar 2, 2014

Closed

v3.0 release notes #805

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment