feature-detect for ES6 Map, Set, WeakMap and WeakSet #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jokeyrhyme somehow I missed this, do you wanna rebase off of master? |
jokeyrhyme
force-pushed
the
es6collections
branch
from
659e922
to
1dc0380
Compare
jokeyrhyme
force-pushed
the
es6collections
branch
from
1dc0380
to
88edf3e
Compare
|
@patrickkettner all rebased and theoretically good to go :) |
patrickkettner
added a commit
that referenced
this pull request
Nov 27, 2015
feature-detect for ES6 Map, Set, WeakMap and WeakSet
|
you're a really cool dude, you know that? |
|
@patrickkettner thanks, that's really life-affirming of you. :) I think that you are also a really cool dude. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature detect shows whether the new collections constructors for ES6 are supported: Map, Set, WeakMap and WeakSet.
Chrome implements all 4, but hides 2 behind a flag. Firefox implements 3.
Polymer requires WeakMap, so detecting this may allow us to skip loading the poly-fill in upcoming browsers.
Part of #1170.