Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-detect for ES6 Map, Set, WeakMap and WeakSet #1396

Merged
merged 1 commit into from Nov 27, 2015

Conversation

@jokeyrhyme
Copy link
Contributor

@jokeyrhyme jokeyrhyme commented Jul 20, 2014

This feature detect shows whether the new collections constructors for ES6 are supported: Map, Set, WeakMap and WeakSet.

Chrome implements all 4, but hides 2 behind a flag. Firefox implements 3.

Polymer requires WeakMap, so detecting this may allow us to skip loading the poly-fill in upcoming browsers.

Part of #1170.

@patrickkettner
Copy link
Member

@patrickkettner patrickkettner commented Nov 27, 2015

@jokeyrhyme somehow I missed this, do you wanna rebase off of master?

@jokeyrhyme jokeyrhyme force-pushed the jokeyrhyme:es6collections branch from 659e922 to 1dc0380 Nov 27, 2015
@jokeyrhyme jokeyrhyme force-pushed the jokeyrhyme:es6collections branch from 1dc0380 to 88edf3e Nov 27, 2015
@jokeyrhyme
Copy link
Contributor Author

@jokeyrhyme jokeyrhyme commented Nov 27, 2015

@patrickkettner all rebased and theoretically good to go :)

patrickkettner added a commit that referenced this pull request Nov 27, 2015
feature-detect for ES6 Map, Set, WeakMap and WeakSet
@patrickkettner patrickkettner merged commit 17d26ca into Modernizr:master Nov 27, 2015
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@patrickkettner
Copy link
Member

@patrickkettner patrickkettner commented Nov 27, 2015

you're a really cool dude, you know that?

@jokeyrhyme
Copy link
Contributor Author

@jokeyrhyme jokeyrhyme commented Nov 27, 2015

@patrickkettner thanks, that's really life-affirming of you. :) I think that you are also a really cool dude. :)

@jokeyrhyme jokeyrhyme deleted the jokeyrhyme:es6collections branch Nov 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants