Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch window.find exception in FF for Android, fixes #1438 #1514

Merged
merged 1 commit into from Oct 28, 2015

Conversation

@ryanhughes
Copy link
Contributor

ryanhughes commented Feb 5, 2015

This prevents lebowskilebowski being left at the top of the page when using Firefox on Android.

Firefox on Android throws a NS_ERROR_NOT_AVAILABLE exception when calling window.find()

Happens on FF35.0 and Android 4.4.4

Screenshot: #1438

@ryanhughes ryanhughes force-pushed the ryanhughes:firefox-css-hyphens branch from 0823e2e to 5efd070 Sep 12, 2015
ryanseddon added a commit that referenced this pull request Oct 28, 2015
Catch window.find exception in FF for Android, fixes #1438
@ryanseddon ryanseddon merged commit 4d6dd2b into Modernizr:master Oct 28, 2015
2 checks passed
2 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@myfonj
Copy link

myfonj commented Jul 23, 2020

Great to see this bug fixed!
There seem to remain some outdated versions of Modernizr scattered around interwebs, but it is nothing you can fix, naturally.

Just one thing would be nice in general in such situation: if you are making some workaround for browser bug, please, make sure the bug was documented and properly reported. And if wasn't, please report it.

It seems this fix overcomes problem that exists in Firefox for years (yes, it is still not fixed), yet I wasn't able to find any trace of report narrowing cause of it from times this hilarious "lebowskilebowskigate" emerged, although it seems it was well known to you (developers) and certainly to author of this fix quite soon it exhibited itself. If it had been reported then, perhaps it would be fixed already and there would not be any manifestation of it at pages with outdated Modernizr today.

Coincidentally, first report matching this bug I could find is from yesterday. Leaving here for reference:
https://bugzilla.mozilla.org/show_bug.cgi?id=1654683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.