New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic test for Cryptographic functions #1661

Merged
merged 1 commit into from Oct 20, 2015

Conversation

Projects
None yet
4 participants
@roblarsen
Contributor

roblarsen commented Sep 17, 2015

Closes #1659

@ryanseddon

This comment has been minimized.

Show comment
Hide comment
@ryanseddon

ryanseddon Sep 18, 2015

Member

Looks like you've got some liniting errors

Member

ryanseddon commented Sep 18, 2015

Looks like you've got some liniting errors

@patrickkettner

This comment has been minimized.

Show comment
Hide comment
@patrickkettner

patrickkettner Sep 20, 2015

Member

@roblarsen what browsers were you able to test in?

Member

patrickkettner commented Sep 20, 2015

@roblarsen what browsers were you able to test in?

@roblarsen

This comment has been minimized.

Show comment
Hide comment
@roblarsen

roblarsen Sep 21, 2015

Contributor

@patrickkettner What I have locally. I'll spin up some screen shots and compare with caniuse...

Contributor

roblarsen commented Sep 21, 2015

@patrickkettner What I have locally. I'll spin up some screen shots and compare with caniuse...

@roblarsen

This comment has been minimized.

Show comment
Hide comment
@roblarsen

roblarsen Sep 21, 2015

Contributor

With the above fix:
https://www.browserstack.com/screenshots/2bd341cf7a590ec047bab12bc7a7757b2f170567

I think this is as expected across that whole pile of browsers

Contributor

roblarsen commented Sep 21, 2015

With the above fix:
https://www.browserstack.com/screenshots/2bd341cf7a590ec047bab12bc7a7757b2f170567

I think this is as expected across that whole pile of browsers

@patrickkettner

This comment has been minimized.

Show comment
Hide comment
@patrickkettner

patrickkettner Sep 21, 2015

Member

just a few nits

  1. following existing convention, this should be feature-detects/crypto.js
  2. I think that the detect name should be crypto
  3. squish down to a single commit plzandthnx
Member

patrickkettner commented Sep 21, 2015

just a few nits

  1. following existing convention, this should be feature-detects/crypto.js
  2. I think that the detect name should be crypto
  3. squish down to a single commit plzandthnx

paulirish added a commit that referenced this pull request Oct 20, 2015

Merge pull request #1661 from roblarsen/crypto
Adding basic test for Cryptographic functions

@paulirish paulirish merged commit 06bf811 into Modernizr:master Oct 20, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@roblarsen roblarsen deleted the roblarsen:crypto branch Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment