Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpeg2000 test #1679

Merged
merged 1 commit into from Sep 28, 2015

Conversation

Projects
None yet
3 participants
@EricWVGG
Copy link
Contributor

EricWVGG commented Sep 24, 2015

JPEG 2000 test, thank you for looking at it.

@modernizr-savage

This comment has been minimized.

Copy link

modernizr-savage commented Sep 24, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 75ae197
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/82039009

(Please note that this is a fully automated comment.)

var image = new Image();

image.onload = image.onerror = function() {
addTest('jpeg2000', image.width == 1, {aliases: ['jpeg-2000']});

This comment has been minimized.

@patrickkettner

patrickkettner Sep 24, 2015

Member

you do not need to add the alias here

@modernizr-savage

This comment has been minimized.

Copy link

modernizr-savage commented Sep 27, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b7f986c
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/82436750

(Please note that this is a fully automated comment.)

@EricWVGG

This comment has been minimized.

Copy link
Contributor Author

EricWVGG commented Sep 27, 2015

wooooooo

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Sep 27, 2015

sorry to be a pest, but could you squash it down to a single commit? Then we will add 'er right in

@EricWVGG EricWVGG force-pushed the EricWVGG:jpeg2000 branch from b7f986c to f18059a Sep 28, 2015

@modernizr-savage

This comment has been minimized.

Copy link

modernizr-savage commented Sep 28, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: f18059a
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/82564307

(Please note that this is a fully automated comment.)

patrickkettner added a commit that referenced this pull request Sep 28, 2015

@patrickkettner patrickkettner merged commit d283289 into Modernizr:master Sep 28, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Sep 28, 2015

Yay!!!

@EricWVGG

This comment has been minimized.

Copy link
Contributor Author

EricWVGG commented Sep 28, 2015

^ savage is complaining, did I screw up?

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Sep 28, 2015

No, savage is messed up at the moment :(

On Sep 28, 2015, at 7:57 AM, Eric Jacobsen notifications@github.com wrote:

^ savage is complaining, did I screw up?


Reply to this email directly or view it on GitHub.

@EricWVGG

This comment has been minimized.

Copy link
Contributor Author

EricWVGG commented Sep 28, 2015

Got it.

Rad. Thank you so much for your patience. This was very exciting for me.

On September 28, 2015 at 11:05:48 AM, patrick kettner (notifications@github.com) wrote:

No, savage is messed up at the moment :(

On Sep 28, 2015, at 7:57 AM, Eric Jacobsen notifications@github.com wrote:

^ savage is complaining, did I screw up?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Sep 28, 2015

my absolute pleasure - I am stoked for you, too!

On Mon, Sep 28, 2015 at 8:06 AM, Eric Jacobsen notifications@github.com
wrote:

Got it.

Rad. Thank you so much for your patience. This was very exciting for me.

On September 28, 2015 at 11:05:48 AM, patrick kettner (
notifications@github.com) wrote:

No, savage is messed up at the moment :(

On Sep 28, 2015, at 7:57 AM, Eric Jacobsen notifications@github.com
wrote:

^ savage is complaining, did I screw up?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#1679 (comment).

patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.