jpeg2000 test #1679

Merged
merged 1 commit into from Sep 28, 2015

Projects

None yet

3 participants

@EricWVGG
Contributor

JPEG 2000 test, thank you for looking at it.

@modernizr-savage

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 75ae197
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/82039009

(Please note that this is a fully automated comment.)

@patrickkettner patrickkettner commented on an outdated diff Sep 24, 2015
feature-detects/img/jpeg2000.js
+ "notes": [{
+ "name": "Wikipedia Article",
+ "href": "http://en.wikipedia.org/wiki/JPEG_2000"
+ }]
+}
+!*/
+/* DOC
+Test for JPEG 2000 support
+*/
+define(['Modernizr', 'addTest'], function(Modernizr, addTest) {
+
+ Modernizr.addAsyncTest(function() {
+ var image = new Image();
+
+ image.onload = image.onerror = function() {
+ addTest('jpeg2000', image.width == 1, {aliases: ['jpeg-2000']});
@patrickkettner
patrickkettner Sep 24, 2015 Member

you do not need to add the alias here

@modernizr-savage

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b7f986c
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/82436750

(Please note that this is a fully automated comment.)

@EricWVGG
Contributor

wooooooo

@patrickkettner
Member

sorry to be a pest, but could you squash it down to a single commit? Then we will add 'er right in

@EricWVGG EricWVGG jpeg 2000 detection
f18059a
@modernizr-savage

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: f18059a
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/82564307

(Please note that this is a fully automated comment.)

@patrickkettner patrickkettner merged commit d283289 into Modernizr:master Sep 28, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@patrickkettner
Member

Yay!!!

@EricWVGG
Contributor

^ savage is complaining, did I screw up?

@patrickkettner
Member

No, savage is messed up at the moment :(

On Sep 28, 2015, at 7:57 AM, Eric Jacobsen notifications@github.com wrote:

^ savage is complaining, did I screw up?


Reply to this email directly or view it on GitHub.

@EricWVGG
Contributor

Got it.

Rad. Thank you so much for your patience. This was very exciting for me.

On September 28, 2015 at 11:05:48 AM, patrick kettner (notifications@github.com) wrote:

No, savage is messed up at the moment :(

On Sep 28, 2015, at 7:57 AM, Eric Jacobsen notifications@github.com wrote:

^ savage is complaining, did I screw up?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

@patrickkettner
Member

my absolute pleasure - I am stoked for you, too!

On Mon, Sep 28, 2015 at 8:06 AM, Eric Jacobsen notifications@github.com
wrote:

Got it.

Rad. Thank you so much for your patience. This was very exciting for me.

On September 28, 2015 at 11:05:48 AM, patrick kettner (
notifications@github.com) wrote:

No, savage is messed up at the moment :(

On Sep 28, 2015, at 7:57 AM, Eric Jacobsen notifications@github.com
wrote:

^ savage is complaining, did I screw up?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#1679 (comment).

patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment