New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WindowBase64 API detection (window.atob && window.btoa) #1696

Merged
merged 1 commit into from Oct 18, 2015

Conversation

Projects
None yet
3 participants
@ChristianUlbrich
Contributor

ChristianUlbrich commented Oct 3, 2015

I needed support for detecting, whether window.atob and window.btoa are present (basically to apply a polyfill for <IE10). I also updated the polyfill info using the suggestion from https://github.com/Modernizr/Modernizr/wiki/HTML5-Cross-Browser-Polyfills#base64-windowatob-and-windowbtoa

@modernizr-savage

This comment has been minimized.

Show comment
Hide comment
@modernizr-savage

modernizr-savage Oct 3, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 23ff394
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/83408648

(Please note that this is a fully automated comment.)

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 23ff394
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/83408648

(Please note that this is a fully automated comment.)

patrickkettner added a commit that referenced this pull request Oct 18, 2015

Merge pull request #1696 from zalari/master
add WindowBase64 API detection (window.atob && window.btoa)

@patrickkettner patrickkettner merged commit a13db53 into Modernizr:master Oct 18, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@patrickkettner

This comment has been minimized.

Show comment
Hide comment
Member

patrickkettner commented Oct 18, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment