New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in css/transforms3d feature detect #1704

Merged
merged 1 commit into from Oct 23, 2015

Conversation

Projects
None yet
5 participants
@JoshuaWise
Contributor

JoshuaWise commented Oct 7, 2015

There was a known bug in the css/transforms3d feature detect, where, if the body tag has a border, this test would incorrectly fail. Feature detects should not fail due to reasonable design decisions. This merge fixes the bug.

@modernizr-savage

This comment has been minimized.

Show comment
Hide comment
@modernizr-savage

modernizr-savage Oct 7, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 8d22aec
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/84028702

(Please note that this is a fully automated comment.)

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 8d22aec
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/84028702

(Please note that this is a fully automated comment.)

@patrickkettner

This comment has been minimized.

Show comment
Hide comment
@patrickkettner

patrickkettner Oct 7, 2015

Member

What known bug are you referring to?

On Oct 6, 2015, at 9:59 PM, Joshua Wise notifications@github.com wrote:

There was a known bug in the css/transforms3d feature detect, where, if the body tag had any margin, padding, or border on it, this test would incorrectly fail. Feature detects should not fail due to reasonable design decisions. This merge fixes the bug.

You can view, comment on, or merge this pull request online at:

#1704

Commit Summary

fixed bug in css/transforms3d feature detect
File Changes

M feature-detects/css/transforms3d.js (9)
Patch Links:

https://github.com/Modernizr/Modernizr/pull/1704.patch
https://github.com/Modernizr/Modernizr/pull/1704.diff

Reply to this email directly or view it on GitHub.

Member

patrickkettner commented Oct 7, 2015

What known bug are you referring to?

On Oct 6, 2015, at 9:59 PM, Joshua Wise notifications@github.com wrote:

There was a known bug in the css/transforms3d feature detect, where, if the body tag had any margin, padding, or border on it, this test would incorrectly fail. Feature detects should not fail due to reasonable design decisions. This merge fixes the bug.

You can view, comment on, or merge this pull request online at:

#1704

Commit Summary

fixed bug in css/transforms3d feature detect
File Changes

M feature-detects/css/transforms3d.js (9)
Patch Links:

https://github.com/Modernizr/Modernizr/pull/1704.patch
https://github.com/Modernizr/Modernizr/pull/1704.diff

Reply to this email directly or view it on GitHub.

@JoshuaWise

This comment has been minimized.

Show comment
Hide comment
@JoshuaWise

JoshuaWise Oct 7, 2015

Contributor

The bug is documented in the code

Of course, that comment describes that the bug occurs when the DIV has margin, padding, or border on it, but the same bug occurs when the body has a border and any position other than position: static.

It can be seen here: http://jsfiddle.net/7yaukc9k/1/

Contributor

JoshuaWise commented Oct 7, 2015

The bug is documented in the code

Of course, that comment describes that the bug occurs when the DIV has margin, padding, or border on it, but the same bug occurs when the body has a border and any position other than position: static.

It can be seen here: http://jsfiddle.net/7yaukc9k/1/

@patrickkettner

This comment has been minimized.

Show comment
Hide comment
@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Oct 20, 2015

Member

I like the fix. Seems good.

Member

paulirish commented Oct 20, 2015

I like the fix. Seems good.

@patrickkettner

This comment has been minimized.

Show comment
Hide comment
@patrickkettner

patrickkettner Oct 20, 2015

Member

keep the merge train a-mergin then

Member

patrickkettner commented Oct 20, 2015

keep the merge train a-mergin then

ryanseddon added a commit that referenced this pull request Oct 23, 2015

Merge pull request #1704 from JoshuaWise/master
fixed bug in css/transforms3d feature detect

@ryanseddon ryanseddon merged commit 6ba72e7 into Modernizr:master Oct 23, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ryanseddon

This comment has been minimized.

Show comment
Hide comment
@ryanseddon

ryanseddon Oct 23, 2015

Member

👍 thanks @JoshuaWise

Member

ryanseddon commented Oct 23, 2015

👍 thanks @JoshuaWise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment