Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiddenscroll: More complete docs #1715

Merged
merged 1 commit into from Oct 16, 2015
Merged

Conversation

@paulirish
Copy link
Member

paulirish commented Oct 16, 2015

FWIW: This feature is actually called "overlay scrollbars" rather than "hidden scrollbars" but it is probably too late to change the property name.

anyhow, lgty?

@modernizr-savage
Copy link

modernizr-savage commented Oct 16, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 20cd58f
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/85790091

(Please note that this is a fully automated comment.)

@@ -3,10 +3,18 @@
"name": "Hidden Scrollbar",
"property": "hiddenscroll",
"authors": ["Oleg Korsunsky"]

This comment has been minimized.

Copy link
@patrickkettner

patrickkettner Oct 16, 2015

Member

we use commas in these here parts

This comment has been minimized.

Copy link
@paulirish

paulirish Oct 16, 2015

Author Member

That's one way to do it.

@modernizr-savage
Copy link

modernizr-savage commented Oct 16, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 998c3ec
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/85791919

(Please note that this is a fully automated comment.)

@patrickkettner
Copy link
Member

patrickkettner commented Oct 16, 2015

can you squish to a single commit then give er the old mergearoo

@paulirish paulirish force-pushed the paulirish:overlayscroll branch from 998c3ec to b0bcb00 Oct 16, 2015
paulirish added a commit that referenced this pull request Oct 16, 2015
hiddenscroll: More complete docs
@paulirish paulirish merged commit 3993ba3 into Modernizr:master Oct 16, 2015
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@paulirish
Copy link
Member Author

paulirish commented Oct 16, 2015

cheers

@modernizr-savage
Copy link

modernizr-savage commented Oct 16, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b0bcb00
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/85816733

(Please note that this is a fully automated comment.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.