New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiddenscroll: More complete docs #1715

Merged
merged 1 commit into from Oct 16, 2015

Conversation

Projects
None yet
3 participants
@paulirish
Member

paulirish commented Oct 16, 2015

FWIW: This feature is actually called "overlay scrollbars" rather than "hidden scrollbars" but it is probably too late to change the property name.

anyhow, lgty?

@modernizr-savage

This comment has been minimized.

Show comment
Hide comment
@modernizr-savage

modernizr-savage Oct 16, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 20cd58f
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/85790091

(Please note that this is a fully automated comment.)

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 20cd58f
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/85790091

(Please note that this is a fully automated comment.)

Show outdated Hide outdated feature-detects/hiddenscroll.js
@@ -3,10 +3,18 @@
"name": "Hidden Scrollbar",
"property": "hiddenscroll",
"authors": ["Oleg Korsunsky"]

This comment has been minimized.

@patrickkettner

patrickkettner Oct 16, 2015

Member

we use commas in these here parts

@patrickkettner

patrickkettner Oct 16, 2015

Member

we use commas in these here parts

This comment has been minimized.

@paulirish

paulirish Oct 16, 2015

Member

That's one way to do it.

@paulirish

paulirish Oct 16, 2015

Member

That's one way to do it.

@modernizr-savage

This comment has been minimized.

Show comment
Hide comment
@modernizr-savage

modernizr-savage Oct 16, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 998c3ec
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/85791919

(Please note that this is a fully automated comment.)

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 998c3ec
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/85791919

(Please note that this is a fully automated comment.)

@patrickkettner

This comment has been minimized.

Show comment
Hide comment
@patrickkettner

patrickkettner Oct 16, 2015

Member

can you squish to a single commit then give er the old mergearoo

Member

patrickkettner commented Oct 16, 2015

can you squish to a single commit then give er the old mergearoo

paulirish added a commit that referenced this pull request Oct 16, 2015

Merge pull request #1715 from paulirish/overlayscroll
hiddenscroll: More complete docs

@paulirish paulirish merged commit 3993ba3 into Modernizr:master Oct 16, 2015

0 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Oct 16, 2015

Member

cheers

Member

paulirish commented Oct 16, 2015

cheers

@modernizr-savage

This comment has been minimized.

Show comment
Hide comment
@modernizr-savage

modernizr-savage Oct 16, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b0bcb00
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/85816733

(Please note that this is a fully automated comment.)

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b0bcb00
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/85816733

(Please note that this is a fully automated comment.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment