New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari 9 fix for sizes detection #1728

Merged
merged 2 commits into from Oct 27, 2015

Conversation

Projects
None yet
3 participants
@aFarkas
Member

aFarkas commented Oct 21, 2015

This fixes #1721. This fix is only async in Safari (8, 9 and maybe 10) and Edge (12).

@modernizr-savage

This comment has been minimized.

Show comment
Hide comment
@modernizr-savage

modernizr-savage Oct 21, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: f2d3d46
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/86700690

(Please note that this is a fully automated comment.)

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: f2d3d46
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/86700690

(Please note that this is a fully automated comment.)

@modernizr-savage

This comment has been minimized.

Show comment
Hide comment
@modernizr-savage

modernizr-savage Oct 21, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 641af45
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/86707104

(Please note that this is a fully automated comment.)

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 641af45
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/86707104

(Please note that this is a fully automated comment.)

patrickkettner added a commit that referenced this pull request Oct 27, 2015

@patrickkettner patrickkettner merged commit 798104f into Modernizr:master Oct 27, 2015

1 of 2 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aFarkas aFarkas deleted the aFarkas:issue-1721-safari-9-sizes-fix branch Oct 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment