Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifiy codec name when check support of mp3 #1740

Merged
merged 1 commit into from Oct 30, 2015

Conversation

Projects
None yet
3 participants
@mems
Copy link
Contributor

mems commented Oct 30, 2015

Firefox return maybe for audio/mpeg and probably for audio/mpeg; codec="mp3" (Firefox 42 OSX 10.10.5)

@modernizr-savage

This comment has been minimized.

Copy link

modernizr-savage commented Oct 30, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 90c8804
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/88371775

(Please note that this is a fully automated comment.)

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Oct 30, 2015

"Generally, a user agent should never return "probably" for a type that allows the codecs parameter if that parameter is not present."

great catch

thanks!

patrickkettner added a commit that referenced this pull request Oct 30, 2015

Merge pull request #1740 from mems/patch-1
Specifiy codec name when check support of mp3

@patrickkettner patrickkettner merged commit eac743c into Modernizr:master Oct 30, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.