Specifiy codec name when check support of mp3 #1740

Merged
merged 1 commit into from Oct 30, 2015

Projects

None yet

3 participants

@mems
Contributor
mems commented Oct 30, 2015

Firefox return maybe for audio/mpeg and probably for audio/mpeg; codec="mp3" (Firefox 42 OSX 10.10.5)

@mems mems Speficy codec name to fix Firefox mp3 support test
90c8804
@modernizr-savage

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 90c8804
Build details: https://travis-ci.org/modernizr-savage/Modernizr/builds/88371775

(Please note that this is a fully automated comment.)

@patrickkettner
Member

"Generally, a user agent should never return "probably" for a type that allows the codecs parameter if that parameter is not present."

great catch

thanks!

@patrickkettner patrickkettner merged commit eac743c into Modernizr:master Oct 30, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment