Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix build query not including setclasses when passed as an option #1772
I stumbled upon this when moving from a manually built Modernizr file to a bower installed one. The build URL provided in the file did not include the
This bug can be demonstrated on the current https://modernizr.com/download site itself:
Example following these steps using
This is happening as the generate script is directly modifying config to remove the setClasses special case option, which means it no longer exists for the rest of the build process (e.g. build-query) to work with.
Another part of this is even if the property was being set, it is using the wrong label anyway, so would still fail to include the
Its usefulness doesn't just lie with copying the build URL for bower, it also makes it more consistently clear what features were intended to be included. Currently, the "bad" URLs work on the site as "Add CSS classes" is checked by default and replaced into the browser history state - shouldn't really depend on that behaviour.
added a commit
this pull request
Nov 27, 2015
On Wed, Dec 2, 2015 at 6:23 AM, Mike Robinson email@example.com