Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alternative check to detect opus codec support #1784

Merged
merged 1 commit into from Jan 18, 2016

Conversation

Projects
None yet
2 participants
@zazabe
Copy link
Contributor

zazabe commented Dec 1, 2015

on mobile (android 5.1.1 / chrome 45), the opus audio codec is supported but elem.canPlayType('audio/ogg; codecs="opus"') will return an empty string and elem.canPlayType('audio/webm; codecs="opus"') will return probably.

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Dec 1, 2015

Can it play it?

@zazabe

This comment has been minimized.

Copy link
Contributor Author

zazabe commented Dec 1, 2015

Yes, you can try it here: http://zazabe.github.io/demo-pages/audio/

video file info:

$ mediainfo opus.weba 
General
Unique ID                                : 73488148176271049887947686502706305755 (0x37494D717E5B8CF6CA5CB2ACEF59DADB)
Complete name                            : opus.weba
Format                                   : WebM
Format version                           : Version 4 / Version 2
File size                                : 17.2 KiB
Duration                                 : 1s 758ms
Overall bit rate                         : 80.3 Kbps
Track name                               : Good News Everyone
Writing application                      : Lavf56.40.101
Writing library                          : Lavf56.40.101

Audio
ID                                       : 1
Format                                   : Opus
Codec ID                                 : A_OPUS
Duration                                 : 1s 758ms
Channel(s)                               : 1 channel
Channel positions                        : Front: C
Sampling rate                            : 48.0 KHz
Bit depth                                : 16 bits
Compression mode                         : Lossy
Default                                  : Yes
Forced                                   : No
@zazabe

This comment has been minimized.

Copy link
Contributor Author

zazabe commented Dec 3, 2015

@patrickkettner could you review it please?

@patrickkettner

This comment has been minimized.

Copy link
Member

patrickkettner commented Dec 3, 2015

Yep

On Dec 3, 2015, at 2:09 AM, Michel Meyer notifications@github.com wrote:

@patrickkettner could you review it please?


Reply to this email directly or view it on GitHub.

patrickkettner added a commit that referenced this pull request Jan 18, 2016

Merge pull request #1784 from zazabe/audio-codec-opus
Add an alternative check to detect opus codec support

@patrickkettner patrickkettner merged commit d1e4f25 into Modernizr:master Jan 18, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.